Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return enum type #525

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Oct 17, 2023

lb4 discover doesn't handle enum properly. This PR implements this workaround for the enum in lb4 discover. For that to work, MySQL connector needs to return the enum type as it is.

Related GitHub issues & PRs:

PR loopbackio/loopback-next#10065

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@aaqilniz aaqilniz force-pushed the fix/return-enum-type branch from d68e445 to fe9cc10 Compare October 17, 2023 11:18
@aaqilniz aaqilniz force-pushed the fix/return-enum-type branch from fe9cc10 to b9f29e5 Compare November 4, 2023 10:45
@aaqilniz aaqilniz marked this pull request as ready for review November 4, 2023 10:45
@aaqilniz
Copy link
Contributor Author

aaqilniz commented Nov 4, 2023

Hi, @dhmlau. Please have a look at the PR. I am not sure what's causing the issue but the tests are failing for this PR too like this one.

And please have a look at the related PR with the fix here.

@samarpanB
Copy link
Collaborator

CI check should pass after merging #539

@samarpanB
Copy link
Collaborator

@aaqilniz can you please rebase this PR ?

@aaqilniz aaqilniz force-pushed the fix/return-enum-type branch 2 times, most recently from 183a804 to 5d4d5c5 Compare November 15, 2023 07:18
@aaqilniz
Copy link
Contributor Author

Hi, @samarpanB. The tests are still failing.

@samarpanB samarpanB mentioned this pull request Nov 15, 2023
5 tasks
@samarpanB
Copy link
Collaborator

@aaqilniz I did the same changes in a new PR #541 and it seemed to be clearing the checks. Can you try by creating a fresh new PR ? Or since you are now part of maintainers you can raise a PR in a new branch here itself without forking the repo. Try that. It seems something is wrong with github action on this PR or on this fork.

@aaqilniz
Copy link
Contributor Author

Hi, @samarpanB. I created a new PR (with the forked one) but it still fails.

I tried pushing a new branch at the original branch (not the forked one), but the request failed with the permission denied error.

@samarpanB
Copy link
Collaborator

@aaqilniz rebase once more please, so that we can check if the CI action passes now.

@aaqilniz aaqilniz force-pushed the fix/return-enum-type branch 2 times, most recently from 6ec9b18 to b4512d3 Compare November 16, 2023 17:50
Signed-off-by: Muhammad Aaqil <[email protected]>
@aaqilniz aaqilniz force-pushed the fix/return-enum-type branch from b4512d3 to 447e0ca Compare November 16, 2023 17:54
@aaqilniz
Copy link
Contributor Author

Hi, @samarpanB. The tests are finally passing. Thanks for the help.

@aaqilniz
Copy link
Contributor Author

Hi, @dhmlau. The tests are finally passing for this PR too. Can you please have a look at the PR please?

@aaqilniz aaqilniz merged commit 23a1b0c into loopbackio:master Nov 17, 2023
5 checks passed
@aaqilniz aaqilniz deleted the fix/return-enum-type branch December 30, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants