enable order by ordinal position for query columns #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaqilniz
force-pushed
the
fix/ordinal_position
branch
6 times, most recently
from
f2d3251 to
cdf35c5
Compare
|
Hi, @dhmlau. Can you please have a look at the PR? The tests are failing due to the access being denied for the given username & password. |
|
Hi, @dhmlau. Thanks for the response. This is strange. The tests are failing for another PR of mine but are working fine for the PR you mentioned. |
|
CI check should pass after merging #539 |
|
@aaqilniz can you please rebase this PR ? |
aaqilniz
force-pushed
the
fix/ordinal_position
branch
2 times, most recently
from
be17483 to
efa09f5
Compare
|
@samarpanB. Tests are finally passing with this PR too. |
samarpanB
reviewed
Nov 21, 2023
|
Hi, @samarpanB. I've updated the PR. Please have a look at it now. The tests are failing due to this change required in |
samarpanB
reviewed
Dec 5, 2023
samarpanB
approved these changes
Dec 29, 2023
|
@aaqilniz tests seem to be failing. Can you rebase and check please ? |
aaqilniz
force-pushed
the
fix/ordinal_position
branch
2 times, most recently
from
0051b18 to
8d87890
Compare
aaqilniz
force-pushed
the
fix/ordinal_position
branch
3 times, most recently
from
0d5c807 to
5275beb
Compare
Signed-off-by: Muhammad Aaqil <[email protected]>
aaqilniz
force-pushed
the
fix/ordinal_position
branch
from
5275beb to
c3777eb
Compare
aaqilniz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lb4 discover analyses the table structures for MySQL using INFORMATION_SCHEMA.COLUMNS
It does not seem to use the ordinal when reading the columns.
This PR adds an option to enable users to get table properties/columns in ordinal_position.
To enable this option, the user can pass an option,
orderBythroughconnectorDiscoveryOptionswhile discovering the models. e.g.--connectorDiscoveryOptions = '{"orderBy":"ordinal_position"}'Checklist
npm testpasses on your machine