Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

JoKircher
Copy link
Contributor

@JoKircher JoKircher commented Feb 20, 2023

Description

Old description: Adds two publisher for the distance to the stop line of an intersection and the next way point. The stop line is indicated by the way point before the intersection. This will be used by the decision tree.

New description: Adds two publisher for the distance to the stop line of an intersection and the distance to the next planned lane change. The behaviour for approaching and entering an intersection is optimized. The behaviour before approaching and entering a lane change was added to the behaviour tree and also optimized.
The behaviour with the Lidar sensor is implemented. To check if we can enter an intersection and enter a lane change event, the distance is checked through the Lidar topic.
The stop line behaviour is implemented. There is no extra topic which publishes the distance to the next stop sign because the xodr file "signal" part only refers to ground truth traffic sign position data which cannot be used. The agent stops before every intersection and every possible traffic sign to check for other cars. Because of that the stop sign behaviour is also covered in this PR.

For testing the environment was switched to the dev environment (town 12).

Time invested

Josef Kircher: 3 h
Simon Erlbacher: 15 h
Niklas Vogel: 15h

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?

Approved decision making with all current informations.

  • intersection behaviour
  • lane change bahaviour
  • distance publisher
  • integrated lidar topics
  • optimized parameter for agent behaviours

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

erlbacsi and others added 30 commits December 5, 2022 14:57
feat(#63): delete file
…-and-evaluate' into 63-feature-opendrive-map-extract-and-evaluate
…com/ll7/paf22 into 154-feature-combine-navigation-data-and-trajectory

# Conflicts:
#	code/planning/launch/planning.launch
…ata-and-trajectory' into 154-feature-combine-navigation-data-and-trajectory

# Conflicts:
#	code/planning/src/planning/preplanner.py
…onment-for-decision-making-tests

# Conflicts:
#	code/agent/config/dev_objects.json
#	code/perception/launch/perception.launch
#	code/planning/behavior_agent/src/behavior_agent/behaviours/lane_change.py
#	code/planning/global_planner/src/Town12.xodr
#	code/planning/global_planner/src/preplanning_2D_tester.py
#	code/planning/global_planner/src/town0.xml
#	code/planning/global_planner/src/town1.xodr
#	code/planning/global_planner/src/visualizer.py
…into 195-feature-create-nodes-to-publish-distance-and-road-option-of-next-global-way-point-and-distance-to-next-intersection

# Conflicts:
#	code/planning/behavior_agent/src/behavior_agent/behaviours/intersection.py
#	code/planning/behavior_agent/src/behavior_agent/behaviours/topics2blackboard.py
#	code/planning/global_planner/launch/global_planner.launch
#	code/planning/global_planner/src/preplanner.py
…ish-distance-and-road-option-of-next-global-way-point-and-distance-to-next-intersection' into 195-feature-create-nodes-to-publish-distance-and-road-option-of-next-global-way-point-and-distance-to-next-intersection

# Conflicts:
#	code/perception/launch/perception.launch
Copy link
Contributor

@timdreier timdreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it, works great! :) Maybe some documentation about this topic would be great!

Is it intended that this PR contains at least #211? If yes, we should keep in mind that we have to review / merge this issue first.

Furthermore it seems like the car runs very fast. Is this intended?

Time to test and review 30 min

@JoKircher
Copy link
Contributor Author

Just tested it, works great! :) Maybe some documentation about this topic would be great!

Is it intended that this PR contains at least #211? If yes, we should keep in mind that we have to review / merge this issue first.

Furthermore it seems like the car runs very fast. Is this intended?

Time to test and review 30 min

There is another branch(#215) incorporation #211 and this branch to do some integration tests. In this branch the velocity tuning is done as well.

@JoKircher
Copy link
Contributor Author

JoKircher commented Mar 22, 2023

I just noted that @vogelnik merged this branch(#215) in here, which might have happened by mistake as it changes the functionality of this branch tremendously and I had no time testing these new changes. So I am not sure, if we could simply merge this PR yet.

@timdreier
Copy link
Contributor

image

I just let the car drive some time, it seems to be stuck in this situation. Could this be caused by this PR?

Only error I could find in the console is this:

ERROR: Invalid session: no stream available with id 8

@JoKircher
Copy link
Contributor Author

image

I just let the car drive some time, it seems to be stuck in this situation. Could this be caused by this PR?

Only error I could find in the console is this:

ERROR: Invalid session: no stream available with id 8

I haven't seen this error before, it might be caused by the new changes but should not be caused by this PR.

@JoKircher JoKircher marked this pull request as draft March 22, 2023 09:33
Copy link
Contributor Author

@JoKircher JoKircher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes seem to break this PR. This PR should have been merged separately and a new PR should have been created for the work done in #215

@vogelnik vogelnik removed their request for review March 22, 2023 13:28
JoKircher and others added 5 commits March 22, 2023 15:19
…ish-distance-and-road-option-of-next-global-way-point-and-distance-to-next-intersection' into 195-feature-create-nodes-to-publish-distance-and-road-option-of-next-global-way-point-and-distance-to-next-intersection
…ption-of-next-global-way-point-and-distance-to-next-intersection' of https://github.com/ll7/paf22 into 195-feature-create-nodes-to-publish-distance-and-road-option-of-next-global-way-point-and-distance-to-next-intersection
@erlbacsi erlbacsi marked this pull request as ready for review March 23, 2023 14:32
@JoKircher JoKircher merged commit c17b411 into main Mar 24, 2023
@JoKircher JoKircher deleted the 195-feature-create-nodes-to-publish-distance-and-road-option-of-next-global-way-point-and-distance-to-next-intersection branch March 24, 2023 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants