Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Commit

Permalink
187 feature dev round sprint 5 (#193)
Browse files Browse the repository at this point in the history
# Description

This PR contains the results of the latest dev talk of today in a .md
file

Fixes #187

## Time invested

Josef Kircher: 1,5 h
Korbinian Stein: 1 h
Marco Riedenauer: 1 h
Gabriel Schwald: 1 h

## Type of change

Please delete options that are not relevant.

- New feature (non-breaking change which adds functionality)

## Does this PR introduce a breaking change?
no

## Most important changes

markdown

# Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works (might be obsolete with CI later on)
- [x] New and existing unit tests pass locally with my changes (might be
obsolete with CI later on)
  • Loading branch information
nylser authored Feb 21, 2023
2 parents 9e9789f + d5339c0 commit 002b555
Show file tree
Hide file tree
Showing 3 changed files with 120 additions and 1 deletion.
2 changes: 1 addition & 1 deletion doc/05_acting/02_acc.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,5 @@ To do so, enable the `AccDistancePublisherDummy` in the acting launch file.

## Also see

* [Dev round 4](../dev_rounds/sprint_4.md)
* [Dev round 4](../07_dev_talks/sprint_4.md)
* [research](../03_research/01_acting/Readme.md)
2 changes: 2 additions & 0 deletions doc/dev_rounds/sprint_4.md → doc/07_dev_talks/sprint_4.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
## Author

Josef Kircher

Julian Graf

Marco Riedenauer

## Date
Expand Down
117 changes: 117 additions & 0 deletions doc/07_dev_talks/sprint_5.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
# Dev talk - Sprint 5

**Summary:** For better communication a developer round is held in this sprint to improve communication and clarify responsibilities.

---

## Author

Josef Kircher

Gabriel Schwald

Marco Riedenauer

Korbinian Stein

## Date

01.02.2023

## Prerequisite

---
<!-- TOC -->
* [Dev talk - Sprint 5](#dev-talk---sprint-5)
* [Author](#author)
* [Date](#date)
* [Prerequisite](#prerequisite)
* [Planning](#planning)
* [Suggestions](#suggestions)
* [Things that need to handled](#things-that-need-to-handled)
* [Results](#results)
* [Acting](#acting)
* [Perception](#perception)
* [Sources](#sources)
<!-- TOC -->

## Planning

### Suggestions

How should be the naming convention for topics?

traffic light message:

string color
float32 distance

traffic sign message:

bool isStop
float distance

speed limit message:

float speedlimit
float distance

acc message:

bool activate/deactivate

### Things that need to handled

* Information from perception
* Are there speed limits on the road? Can you handle these?
* traffic signs are firstly limited to stop signs, I guess? Is the design modular enough to add different signs?
* should there be a state as in the traffic light suggestion? Would keep the message short
* is it alright to handle speed limits differently?
* We might need to track crossing traffic for unsignalized intersections.

* Information from acting
* is it simple enough to have a bool message?
* Speed is published in m/s or km/h?
* this message would only be used to de-active in case of overturn and put back on afterwards and otherwise the ACC could turn on automatically when the distance to the car in front is below a threshold?

### Results

Topic naming: /paf/hero/*

traffic light message:

string color
float32 distance

acc message:

bool activate/deactivate

Open:

traffic sign message:

bool isStop
float distance

speed limit message:

float speedlimit in m/s
float distance

* Perception
* crossing traffic dependent on segmentation/lidar model accuracy
* speed limits are part of opendrive file/ could also have redundent street signs/

* Acting
* Speed in m/s

## Acting

* Unpark routine/ other scenarios handled by acting/ hard coded behavior

## Perception

no questions so far

### Sources

0 comments on commit 002b555

Please sign in to comment.