-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build, for real this time #502
Conversation
e36cd38
to
2ccd9d7
Compare
Looks like this try was misguided. I objdumped the failing tests, and it looks like the core is still somehow trying to fetch data just outside the code segment. In both test programs, the last instruction is compressed |
I think that the right way to proceed is to stop crashing the simulation when accessing stuff outside of the defined memory ranges. The |
This didn't help, either. The core freezes. Looks like fixing this properly requires some proper debugging. I think that, for now, we should just work around the issue. |
d428f1d
to
7d45ab2
Compare
Finally, benchmarks work again. The temporary workaround is to add one more cache line to the code segment. |
Always run the affected workflow before merging. Always run the affected workflow before merging. Always run the affected workflow before merging. Always run the affected workflow before merging.
Summary of the comments:
UnalignedFetcher
sometimes fetches one additional cache line beyond the ones that contain the code. Not really a big problem, but the core freezes on the bus error that can then happen. To work around this issue, an additional cache line is added to code segments.