Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autumn cleaning - move coreblocks utils to transactron #503

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

lekcyjna123
Copy link
Contributor

@lekcyjna123 lekcyjna123 commented Nov 4, 2023

Yet another MR related with #446. This time I move generic stuff from coreblocks/utils to transactron/utils. This commit contains only "drag and drop" movement of files and changes related to imports. No other things have been modified, to allow easy review.

Benchmarks has been started here:
https://github.com/lekcyjna123/coreblocks/actions/runs/6756419996
(failed because of lack of #502)

@lekcyjna123 lekcyjna123 added the refactor Doesn't change functionality, but makes stuff nicer label Nov 4, 2023
Copy link
Member

@tilk tilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple but important step towards making Transactron self-contained.

@tilk tilk changed the title Autums cleaning - move coreblocks utils to transactron Autumn cleaning - move coreblocks utils to transactron Nov 5, 2023
@tilk tilk merged commit 752b986 into kuznia-rdzeni:master Nov 12, 2023
5 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 12, 2023
Co-authored-by: Lekcyjna <[email protected]>
Co-authored-by: Marek Materzok <[email protected]>
tilk added a commit to kuznia-rdzeni/transactron that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Doesn't change functionality, but makes stuff nicer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants