-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payment_methods): receive card_holder_name
in confirm flow when using token for payment
#2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-payment-methods
Area: Payment Methods
labels
Nov 25, 2023
2 tasks
…using token for payment
Chethan-rao
force-pushed
the
get_card_token_data
branch
from
November 25, 2023 14:36
dca80e6
to
80e97c4
Compare
Chethan-rao
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Nov 25, 2023
vspecky
approved these changes
Nov 28, 2023
Narayanbhat166
approved these changes
Nov 28, 2023
Gnanasundari24
approved these changes
Nov 28, 2023
swangi-kumari
approved these changes
Nov 28, 2023
lsampras
pushed a commit
that referenced
this pull request
Nov 28, 2023
…n using token for payment (#2982) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
3 tasks
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-payment-methods
Area: Payment Methods
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently, even though
card_holder_name
was empty,/confirm
would occur without any error. But few connectors requirecard_holder_name
to be sent.This PR includes changes for adding new object
CardToken
inpayment_method_data
object which can be used to send thecard_holder_name
during/confirm
flow along with the token.The token will fetch the stored card from locker. If this response has a
card_holder_name
, then it proceeds as usual without any error. Else it will check whether anyCardToken
object insidepayment_method_data
is sent or not. If not then error is thrown, if present then we update thecard
object received from locker to include thecard_holder_name
passed inCardToken
during/confirm
flowAdditional Changes
Motivation and Context
How did you test it?
list_customer_payment_method
to get thepayment_token
payment_method_data
object passing thecard_holder_name
here along with token in confirm callIf you see the response from confirm call, the
payment_method_data
object will have thecard_holder_name
passed aboveChecklist
cargo +nightly fmt --all
cargo clippy