feat: HS-132: Passing Card Holder Name in Saved Cards Flow #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArushKapoorJuspay
force-pushed
the
feat/dynamic-fields-card
branch
from
2afdcf7 to
82cef11
Compare
ArushKapoorJuspay
force-pushed
the
feat/dynamic-fields-card
branch
from
82cef11 to
3ba2996
Compare
arun-mi
suggested changes
Nov 29, 2023
| if !isAllStoredCardsHaveName { | ||
| acc->Js.Dict.set( | ||
| "payment_method_data.card_token.card_holder_name", | ||
| value->Js.Json.string, |
There was a problem hiding this comment.
Where is this value coming from? Also are complete/empty handled for this case?
There was a problem hiding this comment.
The value is coming from the screenshot.
Complete and empty is handled based on the fieldsArr which are input fields to be rendered, only while creating the requiredFieldsBody are we directly using the required fields object from the payment method list api
arun-mi
approved these changes
Nov 29, 2023
akash-c-k
approved these changes
Nov 29, 2023
akash-c-k
pushed a commit
that referenced
this pull request
Nov 29, 2023
# [0.13.0](v0.12.5...v0.13.0) (2023-11-29) ### Features * HS-132: Passing Card Holder Name in Saved Cards Flow ([#50](#50)) ([62812a4](62812a4))
rising-dragon401
added a commit
to rising-dragon401/hyperswitch-web
that referenced
this pull request
Jul 2, 2024
# [0.13.0](juspay/hyperswitch-web@v0.12.5...v0.13.0) (2023-11-29) ### Features * HS-132: Passing Card Holder Name in Saved Cards Flow ([#50](juspay/hyperswitch-web#50)) ([62812a4](juspay/hyperswitch-web@62812a4))
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
MultiIframeFix Approved-by: Bopanna M J
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
Merge in EXC/orca-elements from gpay/camelcase/case to master * commit '697429f546cf08e68ca0f53aa0cb17eff7d4e277': Added new case for CamelCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description - Required to pass card holder name in confirm call for saved cards
Solution - Backend will check whether the stored card has card_holder_name present in the locker. If it is not there, in that scenario it will check whether it is being passed in the confirm body.
Therefore, added check to render card holder name and pass in the confirm call if the following condition pass -
Sample Confirm Request -
Backend Pr - juspay/hyperswitch#2982