Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] receive card_holder_name in confirm flow when using token for payment #2983

Closed
2 tasks done
Chethan-rao opened this issue Nov 25, 2023 · 0 comments · Fixed by #2982
Closed
2 tasks done

[FEATURE] receive card_holder_name in confirm flow when using token for payment #2983

Chethan-rao opened this issue Nov 25, 2023 · 0 comments · Fixed by #2982
Assignees
Labels
A-payment-methods Area: Payment Methods C-feature Category: Feature request or enhancement

Comments

@Chethan-rao
Copy link
Contributor

Feature Description

Currently, even though card_holder_name was empty, /confirm would occur without any error. But few connectors require card_holder_name to be sent.

Possible Implementation

Add new object CardTokenData in payment_method_data object which can be used to send the card_holder_name during /confirm flow along with the token.
The token will fetch the stored card from locker. If this response has a card_holder_name, then it proceeds as usual without any error. Else it will check whether any CardTokenData object inside payment_method_data is sent or not. If not then error is thrown, if present then we update the card object received from locker to include the card_holder_name passed in CardTokenData during /confirm flow

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@Chethan-rao Chethan-rao added C-feature Category: Feature request or enhancement A-payment-methods Area: Payment Methods labels Nov 25, 2023
@Chethan-rao Chethan-rao added this to the November 2023 Release milestone Nov 25, 2023
@Chethan-rao Chethan-rao self-assigned this Nov 25, 2023
@Chethan-rao Chethan-rao moved this from Candidate to Code Review in hyperswitch - Public Roadmap Nov 25, 2023
@github-project-automation github-project-automation bot moved this from Code Review to Merged in hyperswitch - Public Roadmap Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-payment-methods Area: Payment Methods C-feature Category: Feature request or enhancement
Projects
No open projects
Status: Merged
1 participant