Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [OpenNode] Use connector_request_reference_id as referemce to connector #2596

Merged
merged 2 commits into from
Oct 25, 2023
Merged

feat(connector): [OpenNode] Use connector_request_reference_id as referemce to connector #2596

merged 2 commits into from
Oct 25, 2023

Conversation

shakeel-3
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Use connector_request_reference_id as reference to the connector #2311

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Following are the paths where you can find config files:

  1. hyperswitch/crates/router/src/connector/opennode/transformers.rs

Motivation and Context

To solve inconsistency in RouterData and it solves the Issue #2311

How did you test it?

Need help in doing test?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@shakeel-3 shakeel-3 requested a review from a team as a code owner October 15, 2023 19:43
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 16, 2023
@swangi-kumari swangi-kumari added the C-feature Category: Feature request or enhancement label Oct 20, 2023
@swangi-kumari
Copy link
Contributor

Hey @shakeel-3 ,

Pls address the CI fails

Run cargo +nightly fmt for formatting.

and cargo run --features openapi -- generate-openapi-spec for validating generated openApi spec file. And commit it.

@shakeel-3 shakeel-3 requested review from a team as code owners October 23, 2023 19:17
@shakeel-3 shakeel-3 force-pushed the feature/opennode-use-connector-request-reference-id-2311 branch from aa023e6 to 1ee054c Compare October 23, 2023 19:52
@pixincreate
Copy link
Member

pixincreate commented Oct 24, 2023 •
edited
Loading

Hey @shakeel-3, can you please revert the top most commit in your PR? Since it is already merged into main, I would suggest you using git pull origin main --no-rebase or git pull instead to get those changes in your PR.

@shakeel-3 shakeel-3 force-pushed the feature/opennode-use-connector-request-reference-id-2311 branch 2 times, most recently from 82faeef to 9f4f14c Compare October 24, 2023 09:06
@shakeel-3
Copy link
Contributor Author

Hi @pixincreate, @swangi-kumari
I have revert to top most commit and have Run cargo +nightly fmt and also generated and validated openApi spec file.
If there is any changes to be made please guide me

@shakeel-3 shakeel-3 force-pushed the feature/opennode-use-connector-request-reference-id-2311 branch from e10de9f to 9f4f14c Compare October 24, 2023 22:08
@SamraatBansal
Copy link
Contributor

LGTM!

@SamraatBansal SamraatBansal changed the title feat: use connector_request_reference-id as referemce to connector feat: use connector_request_reference_id as referemce to connector Oct 25, 2023
@SanchithHegde SanchithHegde changed the title feat: use connector_request_reference_id as referemce to connector feat(connector): [OpenNode] Use connector_request_reference_id as referemce to connector Oct 25, 2023
SanchithHegde
SanchithHegde approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @shakeel-3!

@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 25, 2023
@SanchithHegde SanchithHegde linked an issue Oct 25, 2023 that may be closed by this pull request
[FEATURE]: [OpenNode] Use connector_request_reference_id as reference to the connector #2311
Closed
2 tasks
@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 25, 2023
Merged via the queue into juspay:main with commit 96b790c Oct 25, 2023
12 checks passed
@swangi-kumari
Copy link
Contributor

Hey @shakeel-3 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@shakeel-3
Copy link
Contributor Author

@swangi-kumari Thanks a lot

@SagarDevAchar SagarDevAchar mentioned this pull request Oct 27, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Sangamesh26 Sangamesh26 Awaiting requested review from Sangamesh26

Assignees

@shakeel-3 shakeel-3

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [OpenNode] Use connector_request_reference_id as reference to the connector
6 participants
@shakeel-3 @swangi-kumari @pixincreate @SamraatBansal @SanchithHegde @srujanchikke