refactor(connector): [Noon] Remove Default Case Handling

[SagarDevAchar]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

• Addresses Issue [REFACTOR]: [Noon] Remove Default Case Handling #2277
• Modified crates/router/src/connector/noon/transformers.rs
  • Convert NotImplemented to NotSupported in default case

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

No test cases. As In this PR only error message have been populated for all default cases.

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible
• I added a CHANGELOG entry if applicable

[swangi-kumari]

Hey @SagarDevAchar ,
The changes you made is right but you also have to fill the default cases for WalletData (line - 248) Please fill the matching arms for that too.

[SagarDevAchar]

@swangi-kumari got it!

[swangi-kumari]

Hey @SagarDevAchar ,

Pls address the CI fails

Run cargo +nightly fmt for formatting.

and cargo run --features openapi -- generate-openapi-spec for validating generated openApi spec file. And commit it.

[SagarDevAchar]

@swangi-kumari

Pls address the CI fails

Will do!

and cargo run --features openapi -- generate-openapi-spec for validating generated openApi spec file. And commit it.

I cannot seem to get cargo run --features openapi -- generate-openapi-spec or cargo clippy to run successfully
I am stuck with errors like:

error[E0432]: unresolved import `core::any::Demand`
.
.
error[E0432]: unresolved imports `core::any::Demand`, `core::any::Provider`
.
.
error[E0425]: cannot find function `request_ref` in module `any`
.
.

How do I resolve this?
Is there a different version / build of rust I need to be using? (My rustc version is 1.75.0-nightly)

[SanchithHegde]

@SagarDevAchar You don't necessarily need the nightly toolchain for compiling our code, please use the stable toolchain for the purpose. For formatting code alone, you can use the nightly toolchain using the command cargo +nightly fmt.

And I checked the changes in this PR, I don't think you need to specify the generics for the return type (Ok::<NoonPaymentData, E>(...)), only using Ok(...) should suffice.

[SagarDevAchar]

@SanchithHegde

@SagarDevAchar You don't necessarily need the nightly toolchain for compiling our code, please use the stable toolchain for the purpose. For formatting code alone, you can use the nightly toolchain using the command cargo +nightly fmt.

Got it!

And I checked the changes in this PR, I don't think you need to specify the generics for the return type (Ok::<NoonPaymentData, E>(...)), only using Ok(...) should suffice.

Well, on router compilation with just Ok(...), the toolchain gave out errors stating the need for type annotations for Result

Hence, I have added the type annotations to Ok(...) as Ok::<NoonPaymentData, errors::ConnectorError>(...) and the CI Checks succeed (The CI-pr / Spell check failure is due to #2596 which has been merged into main)

Please review and let me know of any changes necessary!

[SanchithHegde]

Looks good to me!

Thanks for the PR, @SagarDevAchar!

[deepanshu-iiitu]

Hey @SagarDevAchar ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!