[uss_qualifier] SCD DSS0210,A2-7-2 – OIR key validation when creating or updating an OIR #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
dss0210-oir-key-validation
branch
3 times, most recently
from
e5bc1a4 to
2c1e517
Compare
Shastick
changed the title
Shastick
changed the title
Shastick
commented
Mar 11, 2024
Comment on lines
462
to
503
| @property | ||
| def last_status_code(self) -> int: | ||
| """Returns the status code of the last query present in this QueryError, | ||
| or 999 if this error contains no queries.""" | ||
| if len(self.queries) == 0: | ||
| return 999 | ||
| return self.queries[-1].status_code | ||
|
|
||
| @property | ||
| def query_timestamps(self) -> List[datetime.datetime]: | ||
| """Returns the timestamps of all queries present in this QueryError.""" | ||
| return [q.request.timestamp for q in self.queries] | ||
|
|
||
| @property | ||
| def last_query(self) -> Optional[Query]: | ||
| """Returns the last query present in this QueryError, or None if this error contains no queries.""" | ||
| if len(self.queries) == 0: | ||
| return None | ||
| return self.queries[-1] | ||
|
|
There was a problem hiding this comment.
These changes are copied from #536, if they need to be discussed please comment over there
Shastick
force-pushed
the
dss0210-oir-key-validation
branch
from
2c1e517 to
71c2fd6
Compare
|
Parked as draft: this will require interuss/dss#1006 to be merged and released first. |
Shastick
force-pushed
the
dss0210-oir-key-validation
branch
5 times, most recently
from
075dea4 to
e028eff
Compare
Shastick
force-pushed
the
dss0210-oir-key-validation
branch
4 times, most recently
from
2ca081e to
bc23f51
Compare
mickmis
reviewed
Mar 21, 2024
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.md
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.py
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.py
Show resolved
Hide resolved
Shastick
force-pushed
the
dss0210-oir-key-validation
branch
from
f3bd4a3 to
8812e81
Compare
|
Updated the following:
|
Shastick
force-pushed
the
dss0210-oir-key-validation
branch
from
8812e81 to
53e8bb5
Compare
Shastick
force-pushed
the
dss0210-oir-key-validation
branch
from
53e8bb5 to
ee8ef32
Compare
mickmis
approved these changes
Mar 22, 2024
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/op_intent_ref_key_validation.py
Outdated
Show resolved
Hide resolved
Shastick
force-pushed
the
dss0210-oir-key-validation
branch
from
ee8ef32 to
e7b7570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers the implicit requirements DSS0210,A2-7-2,2a and DSS0210,A2-7-2,2b:
These are about making sure that an operational intent reference can only be created or mutated if they include the OVNs for (possibly) conflicting entities in their geotemporal vicinity in the creation request.
(Builds on top of #535 for the OIR fragments – please look at the last commit of this PR only)
Resolves #539