Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uss_qualifier] check SCD OIRs properly propagate to every DSS (dss0210,2a-f slice 1/n) #577

Merged
merged 2 commits into from
Mar 22, 2024
Merged

[uss_qualifier] check SCD OIRs properly propagate to every DSS (dss0210,2a-f slice 1/n) #577

merged 2 commits into from
Mar 22, 2024

Conversation

Shastick
Copy link
Contributor

Start covering DSS0210,2: this PR adds the checks for making sure that a new OIR is replicated to and accessible from every DSS

@Shastick Shastick changed the title [uss_qualifier] Add scenario for checking SCD OIRs are properly propagated to all DSS instances [uss_qualifier] scenario to check SCD OIRs properly propagate to every DSS (dss0210,2 slice 1/n) Mar 21, 2024
@Shastick Shastick force-pushed the dss0210-oir-sync-create branch 2 times, most recently from 0fae274 to a2256cf Compare March 21, 2024 14:17
@Shastick Shastick changed the title [uss_qualifier] scenario to check SCD OIRs properly propagate to every DSS (dss0210,2 slice 1/n) [uss_qualifier] check SCD OIRs properly propagate to every DSS (dss0210,2 slice 1/n) Mar 21, 2024
@Shastick Shastick force-pushed the dss0210-oir-sync-create branch from a2256cf to 3b9f63d Compare March 21, 2024 17:34
mickmis
mickmis reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@mickmis mickmis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, but it's mostly looking good.

monitoring/prober/infrastructure.py Outdated Show resolved Hide resolved
monitoring/uss_qualifier/resources/astm/f3548/v21/planning_area.py Outdated Show resolved Hide resolved
...toring/uss_qualifier/scenarios/astm/utm/dss/synchronization/op_intent_ref_synchronization.md

Confirm that the operational intent reference that was just created is properly synchronized across all DSS instances.

#### [Get OIR](../fragments/oir/crud/read.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be first (conceptually)?

Copy link
Contributor Author

@Shastick Shastick Mar 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. The two fragments above are quite tied together, but in order to check if the sync went well one first has to do a GET.

I just noticed that there is too much stuff in the read fragment (it includes stuff for search) -> but I'll split that out in another PR

...toring/uss_qualifier/scenarios/astm/utm/dss/synchronization/op_intent_ref_synchronization.py Outdated
- deletion of an entity on a secondary DSS when it was created on the primary
"""

SUB_TYPE = register_resource_type(381, "Operational Intent Reference")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to change the no. since #543 is getting merged.
Also: a more accurate description would be nice.

...toring/uss_qualifier/scenarios/astm/utm/dss/synchronization/op_intent_ref_synchronization.py Show resolved Hide resolved
...toring/uss_qualifier/scenarios/astm/utm/dss/synchronization/op_intent_ref_synchronization.py Outdated
"Propagated operational intent reference contains the correct start time",
involved_participants,
) as check:
expected_start = expected_oir_params.extents[0].time_start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why [0]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's the first extent, and I assume extents will always be in chronological order? (Here we have a single extent in the list of extents).

Ie, assuming that extents are always in chronological order, the start and end time of an OIR will always be the start time of the first extent and the end time of the last extent, respectively.

(But I might have gotten something wrong?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no there is no such guarantee unfortunately.
However it is easy to get those things with Volume4DCollection, you can parse the volumes with Volume4DCollection.from_f3548v21 and then with Volume4DCollection.time_start and Volume4DCollection.time_end you will have those.

...toring/uss_qualifier/scenarios/astm/utm/dss/synchronization/op_intent_ref_synchronization.py Outdated
"Propagated operational intent reference contains the correct end time",
involved_participants,
) as check:
expected_end = expected_oir_params.extents[-1].time_end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why [-1]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: here we want the last extent so we get the last time stamp, chronologically.

@Shastick Shastick force-pushed the dss0210-oir-sync-create branch from 3b9f63d to 2fcf27b Compare March 22, 2024 15:17
@Shastick Shastick requested a review from mickmis March 22, 2024 15:17
@Shastick Shastick force-pushed the dss0210-oir-sync-create branch from 2fcf27b to e6c3b3f Compare March 22, 2024 15:24
@Shastick Shastick changed the title [uss_qualifier] check SCD OIRs properly propagate to every DSS (dss0210,2 slice 1/n) [uss_qualifier] check SCD OIRs properly propagate to every DSS (dss0210,2a-f slice 1/n) Mar 22, 2024
@Shastick Shastick force-pushed the dss0210-oir-sync-create branch from fa62dad to 74f4f19 Compare March 22, 2024 17:18
@Shastick Shastick mentioned this pull request Mar 22, 2024
Merged
@Shastick Shastick force-pushed the dss0210-oir-sync-create branch from 74f4f19 to 1463787 Compare March 22, 2024 17:45
@mickmis mickmis merged commit a1fd80a into interuss:main Mar 22, 2024
9 checks passed
github-actions bot added a commit that referenced this pull request Mar 22, 2024
@github-actions
[uss_qualifier] check SCD OIRs properly propagate to every DSS (dss02…
902272e 
…10,2a-f slice 1/n) (#577)

* DSS0210,2 sync OIRs – creation

* PR comments a1fd80a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmis mickmis mickmis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shastick @mickmis