Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1D flame driver and remove mixture.py #995

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

tulioricci
Copy link
Collaborator

@tulioricci tulioricci commented Feb 1, 2024

Replace mixture with flame1d since it is possible to compare its solution against Cantera and it is more representative of laminar combustion.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@tulioricci tulioricci mentioned this pull request Feb 1, 2024
8 tasks
@tulioricci tulioricci marked this pull request as ready for review February 9, 2024 16:26
@tulioricci tulioricci requested a review from MTCam February 9, 2024 16:26
@tulioricci tulioricci changed the base branch from main to add-tpe February 15, 2024 13:42
Base automatically changed from add-tpe to main February 15, 2024 17:14
@tulioricci tulioricci mentioned this pull request Apr 29, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant