-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cantera to version 3.0.0 #989
Conversation
91468e7
to
4b52f64
Compare
test/test_eos.py
Outdated
@@ -302,7 +300,7 @@ def inf_norm(x): | |||
pyro_t = pyro_mechanism.get_temperature(pyro_e, tin, yin) | |||
pyro_p = pyro_mechanism.get_pressure(pyro_m, pyro_t, yin) | |||
pyro_h = pyro_mechanism.get_mixture_enthalpy_mass(pyro_t, yin) | |||
pyro_s = pyro_mechanism.get_mixture_entropy_mass(pyro_p, pyro_t, yin) | |||
# pyro_s = pyro_mechanism.get_mixture_entropy_mass(pyro_p, pyro_t, yin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOC, how's come?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Pyrometheus review, we won't add entropy to its native functions. I am wondering if I should remove it completely or add local functions somewhere to keep the verification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is no longer in the base package and the corresponding test was removed there, then this is the right thing to do. I was just curious about the removal. (I'd lean on complete removal).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. 👍
if use_overintegration: | ||
quadrature_tag = DISCR_TAG_QUAD | ||
else: | ||
quadrature_tag = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed because it is useless without spatial operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I am comfortable removing the fluid stuff for this example. It is not wasted on me that it is largely non-participant in this example, but part of the example was showing how to have chem+fluid in the simulation.
My plan is to make However, I can keep the spatial terms in |
I'm not opposed. Hearing your plan makes it seem like a good idea. |
Depends on Updates for Compatibility with the new Cantera 3.0 Release pyrometheus/pyrometheus#75autoignition.py
and further modify it to easy the comparison against pyrometheus and canteramechanism
locationQuestions for the review: