Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TPE examples. #1033

Merged
merged 10 commits into from
May 13, 2024
Merged

Add TPE examples. #1033

merged 10 commits into from
May 13, 2024

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Apr 29, 2024

Adds TPE versions of selected examples to test TPEs with:

  • Inviscid fluid
  • Mixture/Chemistry
  • Viscous flow/noslip BC
  • Thermally-coupled fluid/wall

CC: @a-alveyblanc

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@tulioricci
Copy link
Collaborator

I removed the spatial dependence in autoignition.py in a past PR, so there is no point in adding TPE to it. Better to modify mixture.py or I can add TPE to the flame driver in #995

@MTCam
Copy link
Member Author

MTCam commented Apr 30, 2024

I removed the spatial dependence in autoignition.py in a past PR, so there is no point in adding TPE to it. Better to modify mixture.py or I can add TPE to the flame driver in #995

Removed autoignition-tpe, added mixture-tpe.

@MTCam MTCam requested review from majosm and tulioricci May 11, 2024 04:26
Copy link
Collaborator

@tulioricci tulioricci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

No extra comments because this is just an update to "existing" drivers.

@MTCam MTCam merged commit 0c976e7 into main May 13, 2024
13 checks passed
@MTCam MTCam deleted the add-tpe-examples branch May 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants