Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulgarian Translation 18 #6301

Merged
merged 35 commits into from
Dec 19, 2022
Merged

Bulgarian Translation 18 #6301

merged 35 commits into from
Dec 19, 2022

Conversation

Effektus
Copy link
Contributor

@Effektus Effektus commented Dec 4, 2022

doubleLined Fix

@zenseii
Copy link
Collaborator

zenseii commented Dec 4, 2022

Hi, @Effektus.

When I asked you to make a PR to my fheroes2 fork I meant that you had to do it to this branch:
https://github.com/zenseii/fheroes2/tree/Double-lined-class-translations

That is one option, however, the other which is much simpler is to just write a comment with your changes in the above PR of mine.

Please ask if you have any questions.

@zenseii zenseii added improvement New feature, request or improvement translation Things related to languages and translations labels Dec 5, 2022
@zenseii zenseii added this to the 1.0 milestone Dec 5, 2022
@zenseii zenseii self-requested a review December 5, 2022 20:21
@zenseii
Copy link
Collaborator

zenseii commented Dec 8, 2022

Hi, @Effektus, could you please solve the merge conflicts for this PR? I'll have a look once you've done that.

@Effektus Effektus changed the title Effektus 17 Bulgarian Translation 18 Dec 8, 2022
@zenseii
Copy link
Collaborator

zenseii commented Dec 8, 2022

Thanks, @Effektus. I see that now there are only 2 translations here. I will wait until you have translated the newly added buttons too if that's OK.

files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Effektus.

I left a couple of comments. Please have a look when you have the time to.

files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Effektus, hopefully we'll get some more buttons to translate when the PR for that is merged.

@zenseii
Copy link
Collaborator

zenseii commented Dec 18, 2022

Hi, @Effektus.

The new buttons have been added so please solve the merge conflicts so that these are available.

Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Effektus.
I left a couple of comments. Please have a look when you have the time to.

files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihhub. I've gone through the changes here and it's ready for you to have a look at when you wish to.

@ihhub ihhub merged commit aac05a8 into ihhub:master Dec 19, 2022
@ihhub
Copy link
Owner

ihhub commented Dec 19, 2022

@Effektus , thank you so much for keeping this translation up to date!

@Effektus Effektus deleted the Effektus_17 branch December 19, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants