Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double-lined class name translations #6287

Merged
merged 16 commits into from
Dec 8, 2022

Conversation

zenseii
Copy link
Collaborator

@zenseii zenseii commented Dec 3, 2022

This adds translations to the double-lined class names in case there are more than 4 players in a scenario.

Relates to #5248 and #5244

Follow up to #5983

@zenseii zenseii added improvement New feature, request or improvement translation Things related to languages and translations labels Dec 3, 2022
@zenseii zenseii added this to the 1.0 milestone Dec 3, 2022
@zenseii zenseii changed the title Add Double-lined class translations Add double-lined class translations Dec 3, 2022
@zenseii zenseii changed the title Add double-lined class translations Add double-lined class name translations Dec 3, 2022
@zenseii
Copy link
Collaborator Author

zenseii commented Dec 3, 2022

Hi, translators.

We now have the possibility to have different translations for the class names when there are more than 4 players in a scenario. This makes it possible to have the class names in two lines or in an abbreviated form like "Necroman" for "Necromancer". They have the context "doubleLined|".
It looks like this:
image

I need help with these languages and I put the name of the class that need to be shortened in parenthesis:

German (necromancer)

  • The second line is too long if we divide at "Toten-" so maybe write "Totenbe."?

I would like to ask advice from you @a1exsh and @Laserlicht if you should have the time.

Polish (barbarian, necromancer, sorceress, warlock, wizard)
I would like to ask advice from you here @Arthusppp, @Pulfiarz if you have the time to.

Russian (necromancer, wizard)
I need to ask your help with this @Districh-ru and @undef21 if any of you want to and have the time to look at it.

Belarusian (sorceress, necromancer)
If you have the time to look at this translation @srzkptrsk and @Branikolog then that would be great.

Bulgarian (wizard, warlock, necromancer, sorceress)
This is one I need to ask your help to solve, @Effektus, if you have the time and want to of course.

Hungarian (necromancer, warlock, sorceress)
It would be great if you have the time and would like to help out with this one, @anon569, since you helped out with Hungarian before.

If you want to check this in game you can download a fheroes2 build from this PR's build artifacts and compile a new .mo file as usual.
The translation needs to fit when there are 6 players.

Thank you in advance for your help!

files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
@srzkptrsk
Copy link
Contributor

when there are 6 players.
Thank you in advance for your help!

Something wrong with string for translate
#, fuzzy msgid "" "doubleLined|Necro-\n" "mancer" msgstr "Некра-\n" "мант"

Screenshot 2022-12-03 at 16 30 23

@zenseii
Copy link
Collaborator Author

zenseii commented Dec 3, 2022

Hi, @srzkptrsk.

Make sure to remove the #, fuzzy tag if not the Belarusian translation will not show up. In Poedit this can be done with ctrl+u when highlighting the string.

files/lang/pl.po Outdated Show resolved Hide resolved
files/lang/pl.po Outdated Show resolved Hide resolved
files/lang/pl.po Outdated Show resolved Hide resolved
files/lang/pl.po Outdated Show resolved Hide resolved
@zenseii zenseii mentioned this pull request Dec 4, 2022
@zenseii
Copy link
Collaborator Author

zenseii commented Dec 4, 2022

Hi!
For those not yet completely familiarized with github this link shows the easiest way for you to add your suggested translation to this PR:
#5777 (comment)

files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
files/lang/bg.po Outdated Show resolved Hide resolved
Copy link
Contributor

@Effektus Effektus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@zenseii
Copy link
Collaborator Author

zenseii commented Dec 5, 2022

Hi, @srzkptrsk.

I only need your input on how to split "Чараўніца", or if you think there is no need for that to be split then please correct me.

@Branikolog
Copy link
Collaborator

Hi, @zenseii

Hi, @srzkptrsk.

I only need your input on how to split "Чараўніца", or if you think there is no need for that to be split then please correct me.

I think we can leave them as it is now:
image
Personally, I would like make the word at least 1px thinner, so there would be at least 1 pixel between class names. I believe this could be achieved by future corrections of Cyrillic font.

@srzkptrsk
Copy link
Contributor

Hi, @zenseii

Hi, @srzkptrsk.
I only need your input on how to split "Чараўніца", or if you think there is no need for that to be split then please correct me.

I think we can leave them as it is now: image Personally, I would like make the word at least 1px thinner, so there would be at least 1 pixel between class names. I believe this could be achieved by future corrections of Cyrillic font.

Чараў-/nніца will be better.

@Branikolog
Copy link
Collaborator

Hi, @zenseii

Hi, @srzkptrsk.
I only need your input on how to split "Чараўніца", or if you think there is no need for that to be split then please correct me.

I think we can leave them as it is now: image Personally, I would like make the word at least 1px thinner, so there would be at least 1 pixel between class names. I believe this could be achieved by future corrections of Cyrillic font.

Чараў-/nніца will be better.

If we make capital letters 1 px thinner, class names would look acceptable:
Thin letters
But anyway, we can return to it later and for now split word into 2 lines, as @srzkptrsk proposed.

files/lang/be.po Outdated Show resolved Hide resolved
files/lang/de.po Outdated Show resolved Hide resolved
files/lang/hu.po Outdated Show resolved Hide resolved
files/lang/hu.po Outdated Show resolved Hide resolved
files/lang/hu.po Outdated Show resolved Hide resolved
files/lang/hu.po Outdated Show resolved Hide resolved
@zenseii zenseii requested a review from ihhub December 8, 2022 02:40
@zenseii
Copy link
Collaborator Author

zenseii commented Dec 8, 2022

Hi, @ihhub.

All actively maintained languages have been covered. Please have a look when you have the time to.

@ihhub
Copy link
Owner

ihhub commented Dec 8, 2022

Hi @zenseii , could you please resolve merge conflicts? It's hard for me to do right now as I'm using a phone. Alternatively, I'll do it few hours later.

@zenseii
Copy link
Collaborator Author

zenseii commented Dec 8, 2022

@ihhub, Sure, I didn't notice there were any until you mentioned it.

@ihhub
Copy link
Owner

ihhub commented Dec 8, 2022

@zenseii , they appeared after the latest translation PR merge.

@ihhub ihhub merged commit 5e5166b into ihhub:master Dec 8, 2022
@ihhub
Copy link
Owner

ihhub commented Dec 8, 2022

@zenseii , thank you so much for these changes!

@zenseii zenseii deleted the Double-lined-class-translations branch December 8, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants