-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add double-lined class name translations #6287
Conversation
Hi, translators. We now have the possibility to have different translations for the class names when there are more than 4 players in a scenario. This makes it possible to have the class names in two lines or in an abbreviated form like "Necroman" for "Necromancer". They have the context "doubleLined|". I need help with these languages and I put the name of the class that need to be shortened in parenthesis: German (necromancer)
I would like to ask advice from you @a1exsh and @Laserlicht if you should have the time. Polish (barbarian, necromancer, sorceress, warlock, wizard) Russian (necromancer, wizard) Belarusian (sorceress, necromancer) Bulgarian (wizard, warlock, necromancer, sorceress) Hungarian (necromancer, warlock, sorceress) If you want to check this in game you can download a fheroes2 build from this PR's build artifacts and compile a new .mo file as usual. Thank you in advance for your help! |
Hi, @srzkptrsk. Make sure to remove the |
Hi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Hi, @srzkptrsk. I only need your input on how to split "Чараўніца", or if you think there is no need for that to be split then please correct me. |
Hi, @zenseii
I think we can leave them as it is now: |
Чараў-/nніца will be better. |
If we make capital letters 1 px thinner, class names would look acceptable: |
Co-authored-by: Sergei Ivanov (Districh) <[email protected]>
…zenseii/fheroes2 into Double-lined-class-translations
Hi, @ihhub. All actively maintained languages have been covered. Please have a look when you have the time to. |
Hi @zenseii , could you please resolve merge conflicts? It's hard for me to do right now as I'm using a phone. Alternatively, I'll do it few hours later. |
@ihhub, Sure, I didn't notice there were any until you mentioned it. |
@zenseii , they appeared after the latest translation PR merge. |
@zenseii , thank you so much for these changes! |
This adds translations to the double-lined class names in case there are more than 4 players in a scenario.
Relates to #5248 and #5244
Follow up to #5983