Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: On reload of the pending review details page, the loader will remain visible until the items list is updated (#629) #634

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

R-Sourabh
Copy link
Contributor

Related Issues

#629

Short Description and Why It's Useful

  • Previously, on reload, the onMounted hook in App.vue was running after the onIonViewWillEnter hook in the displayed component, which emits the loader event. This caused a mismatch in the sequence of event handling. To address this, the onMounted hook was replaced with the onBeforeMount hook.
  • Removed the logic of creating the loader from the onBeforeMount hook, as it was being handled asynchronously.
  • With these changes, the hook in App.vue now runs before the hook in the component, ensuring that the event listener is set up before the loader event is emitted from the component.

Contribution and Currently Important Rules Acceptance

src/App.vue Outdated Show resolved Hide resolved
@R-Sourabh R-Sourabh changed the title Fixed: On reload of the pending review details page, the loader will display instead of an empty state (#629) Fixed: On reload of the pending review details page, the loader will remain visible until the items list is updated (#629) Jan 17, 2025
@ymaheshwari1 ymaheshwari1 merged commit 418be2a into hotwax:main Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants