Fixed: On reload of the pending review details page, the loader will remain visible until the items list is updated (#629) #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#629
Short Description and Why It's Useful
onMounted
hook inApp.vue
was running after theonIonViewWillEnter
hook in the displayed component, which emits the loader event. This caused a mismatch in the sequence of event handling. To address this, theonMounted
hook was replaced with theonBeforeMount
hook.onBeforeMount
hook, as it was being handled asynchronously.App.vue
now runs before the hook in the component, ensuring that the event listener is set up before the loader event is emitted from the component.Contribution and Currently Important Rules Acceptance