Skip to content

Commit

Permalink
Merge pull request #634 from R-Sourabh/#629-loader-on-pending-page
Browse files Browse the repository at this point in the history
Fixed: On reload of the pending review details page, the loader will remain visible until the items list is updated (#629)
  • Loading branch information
ymaheshwari1 authored Jan 17, 2025
2 parents a2f12da + cbbf272 commit 418be2a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
12 changes: 4 additions & 8 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<script setup lang="ts">
import { IonApp, IonRouterOutlet, IonSplitPane } from '@ionic/vue';
import { computed, onMounted, onUnmounted, ref } from 'vue';
import { computed, onBeforeMount, onMounted, onUnmounted, ref } from 'vue';
import { loadingController } from '@ionic/vue';
import emitter from "@/event-bus"
import { initialise, resetConfig } from '@/adapter'
Expand Down Expand Up @@ -65,16 +65,12 @@ function dismissLoader() {
}
}
onMounted(async () => {
loader.value = await loadingController
.create({
message: translate("Click the backdrop to dismiss."),
translucent: true,
backdropDismiss: true
});
onBeforeMount(() => {
emitter.on("presentLoader", presentLoader);
emitter.on("dismissLoader", dismissLoader);
})
onMounted(async () => {
if (userProfile.value) {
// Luxon timezone should be set with the user's selected timezone
userProfile.value.timeZone && (Settings.defaultZone = userProfile.value.timeZone);
Expand Down
1 change: 1 addition & 0 deletions src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@
"No facility found.": "No facility found.",
"No facility group found.": "No facility group found.",
"No items found": "No items found",
"No items added to count": "No items added to count",
"No new file upload. Please try again.": "No new file upload. Please try again.",
"No products found.": "No products found.",
"no match found": "no match found",
Expand Down

0 comments on commit 418be2a

Please sign in to comment.