Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: On reload of the pending review details page, the loader will remain visible until the items list is updated (#629) #634

Merged
merged 3 commits into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<script setup lang="ts">
import { IonApp, IonRouterOutlet, IonSplitPane } from '@ionic/vue';
import { computed, onMounted, onUnmounted, ref } from 'vue';
import { computed, onBeforeMount, onUnmounted, ref } from 'vue';
import { loadingController } from '@ionic/vue';
import emitter from "@/event-bus"
import { initialise, resetConfig } from '@/adapter'
Expand Down Expand Up @@ -65,13 +65,7 @@ function dismissLoader() {
}
}

onMounted(async () => {
loader.value = await loadingController
.create({
message: translate("Click the backdrop to dismiss."),
translucent: true,
backdropDismiss: true
});
onBeforeMount(async () => {
ymaheshwari1 marked this conversation as resolved.
Show resolved Hide resolved
emitter.on("presentLoader", presentLoader);
emitter.on("dismissLoader", dismissLoader);

Expand Down
1 change: 1 addition & 0 deletions src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@
"No facility found.": "No facility found.",
"No facility group found.": "No facility group found.",
"No items found": "No items found",
"No items added to count": "No items added to count",
"No new file upload. Please try again.": "No new file upload. Please try again.",
"No products found.": "No products found.",
"no match found": "no match found",
Expand Down
Loading