Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace all mozilla/sops with getsops/sops #168

Closed
wants to merge 2 commits into from

Conversation

lucasfcnunes
Copy link
Contributor

Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
@lucasfcnunes
Copy link
Contributor Author

After this I want to bump the sops 3.7.3 (1+ year old, 173 commit, getsops/sops@v3.7.3...v3.8.0) to 3.8.0

@yxxhero
Copy link
Member

yxxhero commented Sep 17, 2023

@lucasfcnunes please run go mod tidy locally.

@lucasfcnunes
Copy link
Contributor Author

@yxxhero doing it rn

Bump to 3.8.0  because of:
https://github.com/getsops/sops/blob/v3.7.3/go.mod#L1

Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
@lucasfcnunes
Copy link
Contributor Author

lucasfcnunes commented Sep 18, 2023

Bump to 3.8.0 because of: module go.mozilla.org/sops/v3 @ https://github.com/getsops/sops/blob/v3.7.3/go.mod#L1
Causing:

$ go mod tidy
go: github.com/getsops/sops/[email protected]: parsing go.mod:
        module declares its path as: go.mozilla.org/sops/v3
                but was required as: github.com/getsops/sops/v3

Closes #169

@lucasfcnunes
Copy link
Contributor Author

@yxxhero could you approve the pending workflows?

@lucasfcnunes
Copy link
Contributor Author

Guess I'll fix google.golang.org/genproto/googleapis/cloud/secretmanager/v1 in another PR and then rebase here.

@lucasfcnunes
Copy link
Contributor Author

lucasfcnunes commented Sep 18, 2023

@yxxhero could you reopen? I think it's ready to merge.

@yxxhero
Copy link
Member

yxxhero commented Sep 18, 2023

@lucasfcnunes no. please post a new PR. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants