Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix golangci google.golang.org/genproto/googleapis/cloud/secretmanager/v1 is deprecated #171

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

lucasfcnunes
Copy link
Contributor

Failed CI log

Run golangci/golangci-lint-action@v3
prepare environment
run golangci-lint
  Running [/home/runner/golangci-lint-[1](https://github.com/helmfile/vals/actions/runs/6221102957/job/16883100760?pr=168#step:4:1).51.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: SA1019: smpb.AccessSecretVersionRequest is deprecated: Please use types in: cloud.google.com/go/secretmanager/apiv1/secretmanagerpb  (staticcheck)
  Error: SA1019: "google.golang.org/genproto/googleapis/cloud/secretmanager/v1" is deprecated: Please use types in: cloud.google.com/go/secretmanager/apiv1/secretmanagerpb. Please read https://github.com/googleapis/google-cloud-go/blob/main/migration.md for more details.  (staticcheck)
  
  Error: issues found
  Ran golangci-lint in 62044ms

Fix:
https://github.com/googleapis/google-cloud-go/blob/main/migration.md

go run cloud.google.com/go/internal/aliasfix/cmd/aliasfix@latest .
go mod tidy

Resolves #168 CI lint error

Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
@lucasfcnunes
Copy link
Contributor Author

@yxxhero

@yxxhero yxxhero merged commit 6d36d8c into helmfile:main Sep 18, 2023
3 checks passed
@yxxhero
Copy link
Member

yxxhero commented Sep 18, 2023

@lucasfcnunes done

@reegnz reegnz mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants