Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading SOPS to 3.8.0 #170

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Upgrading SOPS to 3.8.0 #170

merged 1 commit into from
Sep 18, 2023

Conversation

reegnz
Copy link
Contributor

@reegnz reegnz commented Sep 18, 2023

SOPS got moved to the CNCF.

The old module path cannot be used anymore, the tidy message is clear on
this:

❯ go mod tidy
go: go.mozilla.org/sops/[email protected]: parsing go.mod:
	module declares its path as: github.com/getsops/sops/v3
	        but was required as: go.mozilla.org/sops/v3

So I changed the module name and ran go mod tidy.

Signed-off-by: Zoltán Reegn [email protected]

@reegnz
Copy link
Contributor Author

reegnz commented Sep 18, 2023

@yxxhero
Copy link
Member

yxxhero commented Sep 18, 2023

@reegnz please fix lint error.

@lucasfcnunes
Copy link
Contributor

Duplicate of #168

SOPS got moved to the CNCF.

The old module path cannot be used anymore, the tidy message is clear on
this:

❯ go mod tidy
go: go.mozilla.org/sops/[email protected]: parsing go.mod:
	module declares its path as: github.com/getsops/sops/v3
	        but was required as: go.mozilla.org/sops/v3

So I changed the module name and ran go mod tidy.

Signed-off-by: Zoltán Reegn <[email protected]>
@reegnz
Copy link
Contributor Author

reegnz commented Sep 18, 2023

Sorry @lucasfcnunes your PR missed my attention. Thanks for fixing the google sdk deprecation though!

@yxxhero the fix in #171 is supposed to have fixed the linter errors.

@reegnz reegnz changed the title Upgrading SOPS to latest release Upgrading SOPS to 3.8.0 Sep 18, 2023
@lucasfcnunes
Copy link
Contributor

lucasfcnunes commented Sep 18, 2023

@yxxhero use this PR instead of mine.

@yxxhero yxxhero merged commit ae04ccd into helmfile:main Sep 18, 2023
3 checks passed
@reegnz reegnz deleted the upgrade_sops branch September 19, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants