Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp Fix for Reading S3 Bucket #238

Closed
wants to merge 2 commits into from
Closed

Temp Fix for Reading S3 Bucket #238

wants to merge 2 commits into from

Conversation

mavaylon1
Copy link
Contributor

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.21%. Comparing base (fedf38e) to head (a00345d).

Files with missing lines Patch % Lines
src/hdmf_zarr/backend.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #238      +/-   ##
==========================================
- Coverage   86.36%   86.21%   -0.15%     
==========================================
  Files           5        5              
  Lines        1188     1190       +2     
  Branches      297      298       +1     
==========================================
  Hits         1026     1026              
- Misses        103      104       +1     
- Partials       59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mavaylon1
Copy link
Contributor Author

Note: this is a temp fix for the benchmarks. real fix will come after export is merged

@rly rly mentioned this pull request Dec 18, 2024
10 tasks
rly added a commit that referenced this pull request Dec 19, 2024
@rly
Copy link
Contributor

rly commented Dec 19, 2024

I incorporated this fix into #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants