Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return chart-path correctly when chart-directory is specified #212

Merged
merged 5 commits into from
Apr 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"scripts": {
"test": "NODE_OPTIONS=--experimental-vm-modules JEST_SUITE_NAME='Unit Tests' jest --runInBand --detectOpenHandles --forceExit --coverage --coverageDirectory='coverage/unit' --testPathIgnorePatterns=\".*/e2e/.*\"",
"test-e2e": "NODE_OPTIONS=--experimental-vm-modules JEST_SUITE_NAME='Jest E2E Tests' JEST_JUNIT_OUTPUT_NAME='junit-e2e.xml' jest --runInBand --detectOpenHandles --forceExit --coverage --coverageDirectory='coverage/e2e' --testPathIgnorePatterns=\\\".*/unit/.*\\\"",
"solo": "NODE_OPTIONS=--experimental-vm-modules node solo.mjs",
"solo": "NODE_OPTIONS=--experimental-vm-modules node --no-deprecation solo.mjs",
"check": "remark . --quiet --frail && eslint .",
"format": "remark . --quiet --frail --output && eslint --fix ."
},
Expand Down
1 change: 1 addition & 0 deletions src/commands/base.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export class BaseCommand extends ShellRunner {
if (chartDir) {
const chartPath = `${chartDir}/${chartReleaseName}`
await this.helm.dependency('update', chartPath)
return chartPath
}

return `${chartRepo}/${chartReleaseName}`
Expand Down
2 changes: 1 addition & 1 deletion version.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@

export const JAVA_VERSION = '21.0.1+12'
export const HELM_VERSION = 'v3.14.2'
export const FST_CHART_VERSION = 'v0.24.2'
export const FST_CHART_VERSION = 'v0.24.3'
export const HEDERA_PLATFORM_VERSION = 'v0.47.0'