Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return chart-path correctly when chart-directory is specified #212

Merged
merged 5 commits into from
Apr 10, 2024
Merged

fix: return chart-path correctly when chart-directory is specified #212

merged 5 commits into from
Apr 10, 2024

Conversation

leninmehedy
Copy link
Member

Description

This pull request changes the following:

  • fix: return chart-path correctly when chart-directory is specified

Related Issues

  • Closes #

@leninmehedy leninmehedy requested a review from a team as a code owner April 9, 2024 03:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024 •
edited
Loading

Unit Test Results

  1 files  ±0   17 suites  ±0   1m 14s ⏱️ -32s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
139 runs  ±0  139 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c8cf1c8. ± Comparison against base commit 7d2499e.

♻️ This comment has been updated with latest results.

@leninmehedy leninmehedy requested a review from a team as a code owner April 9, 2024 03:52
tomzhenghedera
tomzhenghedera previously approved these changes Apr 9, 2024
View reviewed changes
jeromy-cannon
jeromy-cannon previously approved these changes Apr 9, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024 •
edited
Loading

E2E Test Results

 1 files  ±0  10 suites  ±0   8m 51s ⏱️ - 1m 56s
74 tests ±0  74 ✅ ±0  0 💤 ±0  0 ❌ ±0 
76 runs  ±0  76 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c8cf1c8. ± Comparison against base commit 7d2499e.

♻️ This comment has been updated with latest results.

@codacy-production Codacy Production
Copy link

codacy-production bot commented Apr 9, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% (target: -1.00%) ✅ 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7d2499e) 2870 2221 77.39%
Head commit (c8cf1c8) 2875 (+5) 2225 (+4) 77.39% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#212) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@codecov Codecov
Copy link

codecov bot commented Apr 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.10%. Comparing base (7d2499e) to head (d317afa).

❗ Current head d317afa differs from pull request most recent head c8cf1c8. Consider uploading reports for the commit c8cf1c8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   77.13%   77.10%   -0.03%     
==========================================
  Files          33       33              
  Lines        3415     3416       +1     
  Branches      636      636              
==========================================
  Hits         2634     2634              
- Misses        781      782       +1
Files Coverage Δ
version.mjs 100.00% <100.00%> (ø)
src/commands/base.mjs 89.65% <0.00%> (-3.21%) ⬇️

Impacted file tree graph

@leninmehedy leninmehedy merged commit 90616cc into main Apr 10, 2024
22 checks passed
@leninmehedy leninmehedy deleted the fix-chart-path branch April 10, 2024 08:19
swirlds-automation added a commit that referenced this pull request Apr 19, 2024
@swirlds-automation
chore(release): 0.24.0 [skip ci]
29fe5ee 
## [0.24.0](v0.23.0...v0.24.0) (2024-04-19)

### Features

* add `solo account create` account alias support ([#227](#227)) ([fe865f8](fe865f8))
* add node refresh subcommand ([#211](#211)) ([d1017d8](d1017d8))
* add node refresh subcommand ([#211](#211)) ([d38918c](d38918c))
* adding some type check ([#217](#217)) ([d055496](d055496))
* allow solo to deploy pre-configured resource profiles ([#175](#175)) ([fef8a48](fef8a48))

### Bug Fixes

* add recursive option to mkdir ([#215](#215)) ([9d9a126](9d9a126))
* address PR comments from [#211](#211) ([#224](#224)) ([6cc237c](6cc237c))
* return chart-path correctly when chart-directory is specified ([#212](#212)) ([90616cc](90616cc))
* update how documented generated ([#216](#216)) ([7d2499e](7d2499e))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@tomzhenghedera tomzhenghedera tomzhenghedera left review comments

@nathanklick nathanklick Awaiting requested review from nathanklick

Assignees
No one assigned
Labels
released on @0.24.x released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leninmehedy @swirlds-automation @jeromy-cannon @tomzhenghedera