Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use common Hiero Gradle config #2033

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

jjohannes
Copy link
Contributor

@jjohannes jjohannes commented Oct 9, 2024

Description:

Before this can be integrated:

Related issue(s):

hashgraph/hedera-services#14255
#1794
#1669
#2054

@jjohannes jjohannes self-assigned this Oct 9, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 8 times, most recently from 3da628a to a2ee99a Compare October 11, 2024 08:19
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from a2ee99a to 3590ef4 Compare October 16, 2024 06:29
@jjohannes jjohannes changed the title build: use common Hedera Gradle config build: use common Hiero Gradle config Nov 4, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 4 times, most recently from b638150 to c8f142d Compare December 9, 2024 14:23
@jjohannes jjohannes marked this pull request as ready for review December 9, 2024 14:38
@jjohannes jjohannes requested review from a team as code owners December 9, 2024 14:38
developers.properties Outdated Show resolved Hide resolved
mishomihov00
mishomihov00 previously approved these changes Dec 11, 2024
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to:
.github/workflows/build.yml
.github/workflows/release-artifacts.yml

@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 4 times, most recently from 292570a to 0a47fed Compare December 11, 2024 13:56
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 0a47fed to 5ae7eda Compare December 11, 2024 14:38
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 5ae7eda to a749dbb Compare December 11, 2024 15:10
@0xivanov
Copy link
Contributor

Hey @jjohannes , i will prioritise this PR and #2045 in the next milestone

Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to:
.github/dependabot.yml
.github/workflows/build.yml
.github/workflows/release-artifacts.yml

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jjohannes

@0xivanov
Copy link
Contributor

@hashgraph/devops-ci @hashgraph/release-engineering-managers Would need a review on this one

@0xivanov 0xivanov merged commit 0a72de5 into main Dec 13, 2024
7 checks passed
@0xivanov 0xivanov deleted the 14255-reusable-gradle-config branch December 13, 2024 15:36
jjohannes added a commit that referenced this pull request Dec 16, 2024
This now follows a similar setup as in hedera-services.
This update was missed in #2033.

Signed-off-by: Jendrik Johannes <[email protected]>
jjohannes added a commit that referenced this pull request Dec 16, 2024
This now follows a similar setup as in hedera-services.
This update was missed in #2033.

Signed-off-by: Jendrik Johannes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants