build: repair running test AND testIntegration with code coverage on CI #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now follows a similar setup as in hedera-services. This update was missed in #2033. Signed-off-by: Jendrik Johannes <[email protected]>
jjohannes
force-pushed
the
2033-repair-test-running-and-coverage
branch
from
d8d505b to
43c6383
Compare
Signed-off-by: Jendrik Johannes <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
============================================
+ Coverage 82.20% 82.61% +0.41%
- Complexity 3588 4038 +450
============================================
Files 186 205 +19
Lines 11697 12927 +1230
Branches 1150 1274 +124
============================================
+ Hits 9615 10680 +1065
- Misses 1604 1792 +188
+ Partials 478 455 -23 ☔ View full report in Codecov by Sentry. |
|
Sorry for breaking this in #2033 @0xivanov The setup in this repository is different (compared to hedera-services) as there the report is aggregated from multiple projects, while here we so far only have tests in one project ( It should work now, The Tests and Integration Tests run again and the coverage is reported. |
0xivanov
approved these changes
Dec 16, 2024
rbarkerSL
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This now follows a similar setup as in hedera-services. This update was missed in #2033.