Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename hedera to hiero in gradle files #2054

Closed
Tracked by #2017
0xivanov opened this issue Oct 29, 2024 · 6 comments
Closed
Tracked by #2017

Rename hedera to hiero in gradle files #2054

0xivanov opened this issue Oct 29, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@0xivanov
Copy link
Contributor

Problem

Solution

Alternatives

No response

@0xivanov
Copy link
Contributor Author

0xivanov commented Nov 1, 2024

@jjohannes Would you be able to take a look at this? I've done the renaming for the .java files here. but I am not very familiar with the gradle structure in the sdk.

@jjohannes
Copy link
Contributor

@0xivanov with the change of the Java packages and Module Name, we should also change the group the SDK is published under (IMO). This would be here: https://github.com/hashgraph/hedera-sdk-java/blob/main/gradle/plugins/src/main/kotlin/com.hedera.gradle.base.gradle.kts#L21
I suggest to change that in your PR as well.

The Gradle configuration files (convention plugins) also use the hedera in their IDs, but that is only internal to our build and has no influence on the published artifacts. I will change these to org.hiero.* as part of #2033.

@0xivanov
Copy link
Contributor Author

0xivanov commented Nov 4, 2024

Sounds good!

@rwalworth rwalworth modified the milestones: v2.44.0, v2.45.0 Nov 12, 2024
@0xivanov
Copy link
Contributor Author

Hi @jjohannes , has there been any progress on this issue?

@jjohannes
Copy link
Contributor

Everything is prepared, but we are still waiting to get all credentials/singing keys for the new Hiero org to be able to publish the first version of https://github.com/hiero-ledger/hiero-gradle-conventions

I expect this to happen any day now.

As soon as it is done, I will update #2033 in a way that it also resolves this issue.

@SimiHunjan SimiHunjan modified the milestones: v2.45.0, v2.46.0 Nov 26, 2024
@rwalworth rwalworth modified the milestones: v2.46.0, v2.47.0 Dec 10, 2024
@jjohannes
Copy link
Contributor

Done by #2033

The group for publishing (Maven Coordinates) is also defined in a Gradle file – settings.gradle.kts – but should be changed together with the packages as it is part of the "user facing API". See #2141 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants