Move the task runner to ESM #27247
Merged
Move the task runner to ESM #27247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
reviewed
Jun 21, 2024
|
We could improve the typing of tasks with something like: /** @type {import('../../task-runner/task.mjs').Task} */
/** @typedef {{
description: string;
task: Array<() => Promise<void> | Task>;
concurrent?: boolean;
}} Task */ |
mxdvl
force-pushed
the
mxdvl/esm
branch
3 times, most recently
from
ac2adf1 to
b0d1445
Compare
mxdvl
force-pushed
the
mxdvl/esm
branch
2 times, most recently
from
3593f69 to
79caf05
Compare
remove unused and gone tasks
mxdvl
commented
Jun 24, 2024
mxdvl
commented
Jun 24, 2024
| ) | ||
| .demand(1) | ||
| .help() | ||
| .alias('h', 'help') // eslint-disable-line newline-per-chained-call | ||
| .alias('h', 'help') |
There was a problem hiding this comment.
as requested by @JamieB-gu in #27256
This was referenced Jun 25, 2024
georgeblahblah
approved these changes
Jun 25, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-FRONTS-PROD
and removed
Pending-on-FRONTS-PROD
labels
|
Seen on FRONTS-PROD (merged by @mxdvl 12 minutes and 2 seconds ago)
|
|
Seen on ADMIN-PROD (merged by @mxdvl 12 minutes and 8 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Enable bumping ESM-only dependencies of the task runner, such as
cpyWhat does this change?
Refactor all the CommonJS of the task runner to use ESM instead.
Note
This does not yet use ESM for the tasks themselves
Screenshots
Checklist