Use Listr directly for the task runner #27260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
force-pushed
the
mxdvl/listr-directly
branch
4 times, most recently
from
3360a7e to
f001572
Compare
mxdvl
commented
Jun 25, 2024
There was a problem hiding this comment.
Note this file is actually unused anywhere… so worth removing as a follow-up
rather than a custom wrapper, we can use the Listr API directly to peel off layers of abstraction, reduce custom code, and benefit from the library’s types.
mxdvl
force-pushed
the
mxdvl/listr-directly
branch
from
125a6e6 to
7aa10bc
Compare
abeddow91
reviewed
Jun 26, 2024
| task: () => compile('atoms/*.scss'), | ||
| }, | ||
| ], | ||
| { concurrent: !!ctx.verbose ? false : true }, |
There was a problem hiding this comment.
Whats the reason to switch concurrency here?
There was a problem hiding this comment.
Previously, when concurrent was true, listrify would read this value and convert it to true or false based on a series of check. This makes it more explicit at the point of creation.
abeddow91
reviewed
Jun 26, 2024
Comment on lines
+93
to
+97
| new Listr(taskModules, { | ||
| collapse: true, | ||
| renderer: IS_VERBOSE ? VerboseRenderer : 'default', | ||
| concurrent: VERBOSE ? false : true, | ||
| }) |
There was a problem hiding this comment.
😍 This is great! Removes a lot of complexity!
abeddow91
approved these changes
Jun 26, 2024
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @mxdvl 14 minutes and 10 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Peel off layers of abstraction and benefit from the library’s types.
Follow-up on #27247
What does this change?
taskexports as beingListrTasknewListrfor subtasksconcurrencyexplicit for subtask and dependent on contextstringtask explicitly callexecalistrifyandexecfunction as they are redundant