Format the task runner #27256
Merged
Format the task runner #27256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no --dev flag necessary, just explicit imports runner is extensionless, so Prettier needs to be called explicitely on it
JamieB-gu
approved these changes
Jun 24, 2024
Comment on lines
+63
to
+65
| .alias('h', 'help') // eslint-disable-line newline-per-chained-call | ||
| .version() | ||
| .alias('v', 'version').argv; // eslint-disable-line newline-per-chained-call |
There was a problem hiding this comment.
Can these comments go now?
There was a problem hiding this comment.
They probably can, but easier to do once we’ve moved to ESM in the next PR. Here I’ve mostly just run prettier tools/task-runner/runner --write and updated IS_DEV part of getTasksFromModule
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @mxdvl 10 minutes and 58 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @mxdvl 11 minutes and 17 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Make the ESM migration as smooth as possible in #27247
What does this change?
--devflag necessary, just explicit imports