Retire ENForm block

[comzeradd]

Summary

Removes all code exclusively required for the ENForm block.

In addition:

• Removes relevant styles from Counter block
• Removes relevant locale text domains
• Removes twig templates that no other block uses
• Adjust locale text domains
• Added migration to clean up database from block settings and forms

---

Ref: https://jira.greenpeace.org/browse/PLANET-7673

Testing

1. Before switching to this branch, enable Engaging Networks from Planet 4 > Features.
2. Add some "random" keys into Engaging Networks > Settings. You probably already have some data there, since defaultcontent still does.
3. Browse to Engaging Networks" > Add Form and create a new form. Same as above, you probably already have one as part of the defaultcontent database.
4. Switch to this branch and build assets (npm run build:assets).
5. Run the migration (npx wp-env run cli wp p4-run-activator)
6. Verify it actually removed all relevant content:
   • There should be no feature_engaging_networks option in that array:

   npx wp-env run cli wp option get planet4_features

   • You should get an Error: Could not get 'p4en_main_settings' option. Does it exist?

   npx wp-env run cli wp option get p4en_main_settings

   • You should get an empty array:

   npx wp-env run cli wp post list --post_type=p4en_form

7. In general, check code into detail in case something removed is still needed. I removed completely the block_templates and Controllers/API folders, since they don't seem to be used anywhere else besides ENForm block.

[planet-4]

Test instance is ready 🚀

🌑 phobos | admin | blocks report | CircleCI | composer-local.json

⌚ 2024.12.16 09:12:24

[mardelnet]

I see there are still elements related to the ENForm in the plugin repo (check here and here, for example). Is it worth it to remove them, as well?

[mardelnet]

There's a conflict with the file tests/e2e/blocks/enform.spec.js that prevents this branch from being merged. Would you mind checking it?

[comzeradd]

I see there are still elements related to the ENForm in the plugin repo (check here and here, for example). Is it worth it to remove them, as well?

These results are coming from the blocks plugin repo, so these are removed in the other PR: greenpeace/planet4-plugin-gutenberg-blocks#1265

[mardelnet]

@comzeradd, for some reason, on my local installation the migration script removes all the ENForms except this one (ID 855):

[comzeradd]

@comzeradd, for some reason, on my local installation the migration script removes all the ENForms except this one (ID 855):

There was an error on the post type constants. It's looking up for action but the correct name of that post type is p4_action. I fixed it now in this PR and it removes even that instance of ENForm.

[mardelnet]

Well done!