Remove ENForm block #1265
Merged
Remove ENForm block #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comzeradd
force-pushed
the
retire-enform
branch
4 times, most recently
from
8a325c4 to
4c816c5
Compare
planet-4
added a commit
to greenpeace/planet4-test-pandora
that referenced
this pull request
Dec 9, 2024
/unhold edcacc91-cc6d-40ad-8fb9-f593ee10ffa1
Test instance is ready 🚀🌑 pandora | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.12.16 13:47:55 |
mardelnet
reviewed
Dec 16, 2024
mardelnet
reviewed
Dec 16, 2024
Following its retirement from the theme code. This also removes the Counter block to avoid cleaning it up from ENForm related code. Ref: https://jira.greenpeace.org/browse/PLANET-7673
comzeradd
force-pushed
the
retire-enform
branch
from
4c816c5 to
555b505
Compare
Yes, those are all ENForm related. I had already removed the code that uses the Models classes, so I just removed those too. |
planet-4
added a commit
to greenpeace/planet4-test-pandora
that referenced
this pull request
Dec 16, 2024
/unhold 07d380df-52b6-44db-bd51-ec565c5c9f49
mardelnet
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following its retirement from the theme code.
This also removes the Counter block to avoid cleaning it up from ENForm related code.
Ref: https://jira.greenpeace.org/browse/PLANET-7673
Testing