-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(types)!: move worker type to server and nest API object #997
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
+ Coverage 62.64% 62.97% +0.33%
==========================================
Files 345 347 +2
Lines 10304 10564 +260
==========================================
+ Hits 6455 6653 +198
- Misses 3373 3427 +54
- Partials 476 484 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall. it seems like the we would have to mark this as breaking with the field name change here https://github.com/go-vela/server/pull/997/files#diff-a0e7f3f0dda9cc1df4b6b67ce3b81bdf66406453632b6777ad555838eaea080aR22 (see https://github.com/go-vela/types/blob/bab8877f46068f83fc2775f6148303be018ae248/library/worker.go#L20 for reference). in local testing, "running_builds" never showed up in the response. i believe we need accompanying changes in sdk-go and worker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Proposal ref: go-vela/community#639
@jbrockopp saw this refactor as a good opportunity to migrate off of the
go-vela/types
repo a while back.Starting with worker since it is a very low user-requested resource but is still leveraged often enough by the Vela application that we would know if something wasn't quite right very early.
I was also itching to start with worker, as the admin page would benefit greatly from clickable build links sourced from the
ListWorkers
API response.As a visual:
OLD
NEW