Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(user)!: migrate from types repo #1106

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

Continuing efforts from:

Also removing deprecated hash field. Will need to be added to migration docs, hence the breaking change marker.

@ecrupper ecrupper requested a review from a team as a code owner April 12, 2024 15:56
database/schedule/create.go Outdated Show resolved Hide resolved
scm/github/authentication.go Show resolved Hide resolved
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 94.06780% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 65.22%. Comparing base (fe803f8) to head (40acf3c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
+ Coverage   64.47%   65.22%   +0.74%     
==========================================
  Files         370      371       +1     
  Lines       11791    11961     +170     
==========================================
+ Hits         7602     7801     +199     
+ Misses       3672     3657      -15     
+ Partials      517      503      -14     
Files Coverage Δ
api/build/skip.go 100.00% <ø> (ø)
api/types/executor.go 100.00% <ø> (ø)
api/types/repo.go 100.00% <100.00%> (ø)
api/types/user.go 100.00% <100.00%> (ø)
compiler/native/environment.go 85.71% <100.00%> (ø)
compiler/native/native.go 87.95% <100.00%> (ø)
compiler/registry/github/template.go 53.84% <100.00%> (ø)
database/repo/count_user.go 100.00% <100.00%> (ø)
database/repo/list_user.go 86.20% <100.00%> (ø)
database/repo/repo.go 92.66% <100.00%> (+23.33%) ⬆️
... and 21 more

wass3rw3rk
wass3rw3rk previously approved these changes Apr 12, 2024
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super minor thing

api/build/skip.go Outdated Show resolved Hide resolved
timhuynh94
timhuynh94 previously approved these changes Apr 12, 2024
@ecrupper ecrupper dismissed stale reviews from timhuynh94 and wass3rw3rk via e91a19c April 12, 2024 17:05
@ecrupper ecrupper merged commit 04f9308 into main Apr 12, 2024
13 of 16 checks passed
@ecrupper ecrupper deleted the refactor/nested-api/user branch April 12, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants