v4 Updates

[AndrewKahr]

Changes

• Add containerRegistryRepository, containerRegistryImageVersion, dockerCpuLimit, dockerMemoryLimit, and dockerIsolationMode information
• Change windows-2019 to windows-2022 in getting started
• Bumped out-of-date action versions throughout example workflows
• Update out-of-date parameter on Android deployment workflow example

Related PRs

• Feature/windows upgrades unity-builder#588
• Update Windows to 2022 and enable Android Windows Images docker#231
• License Activation fixes and Github Annotations unity-builder#590

Related Issues

• alf->ulf license activation no longer possible for personal licenses #408
• https://github.com/game-ci/unity-actions/issues/182

Checklist

• Read the contribution guide and accept the
  code of conduct
• Readme (updated or not needed)
• Tests (added, updated or not needed)

[github-actions]

[github-actions]

Visit the preview URL for this PR (updated for commit 8ebb6b5):

https://game-ci-5559f--pr433-windows-updates-e4duf1pm.web.app

_{(expires Wed, 22 Nov 2023 04:15:25 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 1f0574f15f83e11bfc148eae8646486a6d0e078b}

[GabLeRoux]

nitpick: simply wondering if we should have consistency with "Windows docker container" vs "docker container" in here.

[GabLeRoux]

Same nitpick about consistency for nitpick: "Windows docker container" vs "docker container"

[GabLeRoux]

I find the repetition of default in here a bit confusing, maybe we should replace with recommended instead? really not sure about this one

Suggested change

	will pick the default mode as described by Microsoft where server versions use process and desktop
	will pick the recommended mode as described by Microsoft where server versions use process and desktop

[GabLeRoux]

Here's a suggestion combining some the above ideas. I used a list for m and g units for dockerMemoryLimit. Using e.g. instead of ie for examples. I'm definitely ok to merge as it is right now by the way.

---

dockerCpuLimit

Number of CPU cores to assign to the Docker container. Defaults to all available cores when no value is specified. Can accept fractional values, e.g., 0.5 for half of a CPU core's execution time.

required: false default: ""

dockerMemoryLimit

Amount of memory to assign to the Docker container. Defaults to 95% of total system memory rounded down to the nearest megabyte on Linux and 80% on Windows. If the platform is unrecognized, it defaults to 75% of total system memory. To manually specify a value, use the format <number><unit>. The units can be:

• m: Megabytes (e.g., 512m = 512 megabytes)
• g: Gigabytes (e.g., 4g = 4 gigabytes)

required: false default: ""

dockerIsolationMode

Isolation mode to use for the Docker container when running on Windows. Can be one of:

• process
• hyperv
• default: This mode will choose the recommended mode as described by Microsoft. Server versions will use process, while desktop versions will use hyperv.

required: false default: "default"

[AndrewKahr]

I like this a lot better, will be using this strategy. Excellent suggestion!

[davidmfinol]

I see you replaced androidAppBundle with androidExportType same time as I did! 😆
I can just close the other PR I raised.

[AndrewKahr]

Haha yea I realized a bit too late. Feel free to merge yours so that it hits v3 while we wait for v4 changes to wrap up which might take a bit. I backported the change to the v3 docs in this PR so shouldn't be an issue