Additional Fixes and Improvements

[AndrewKahr]

Changes

• Windows now exits with the proper exit codes. This mirrors Ubuntu behavior properly now and means we do not need the error parsing logic to handle error conditions which means we should be back to v2 behavior.
• Allow customizing image registry/image version
• Only create the licensing directory on Mac if it doesn't already exist. Don't delete the folder on build complete. This means builds nominally shouldn't need sudo permissions, very useful for self-hosted runners.
• Pick correct architecture when installing macos editor to support both x86 and arm-based systems

Related Issues

• "Build succeeded" but still getting "There was an error..." #564
• Disabling the check for the "Build results" output? #563
• Job with manualExit: true fails without a proper reason #578
• Upgrading to builder@v3 broke iOS builds #572
• "unityci/editor:ubuntu-2022.3.13f1-windows-mono-2" image not hosted on dockerhub #594
• Preserve license folder on Mac, if it already exists #595

Related PRs

• GAME_CI_BUILD_SUCCESS and GAME_CI_STEP_SUMMARY #576: I believe this PR is no longer needed since the exit code should be working properly now
• Support architecture parameter #591: Merging this in with this PR to get v4 out a bit quicker. Credit to @dcvz for providing this code
• v4 Updates documentation#433

Checklist

• Read the contribution guide and accept the
  code of conduct
• Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
  in the documentation repo)
• Readme (updated or not needed)
• Tests (added, updated or not needed)

[github-actions]

[codecov-commenter]

Codecov Report

Merging #596 (6d40668) into main (caa0a81) will increase coverage by 0.06%.
The diff coverage is 81.81%.

❗ Current head 6d40668 differs from pull request most recent head e526ef5. Consider uploading reports for the commit e526ef5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   37.22%   37.29%   +0.06%     
==========================================
  Files          76       76              
  Lines        3054     3057       +3     
  Branches      610      610              
==========================================
+ Hits         1137     1140       +3     
  Misses       1917     1917              

Files	Coverage Δ
src/model/build-parameters.ts	90.00% <ø> (ø)
src/model/image-tag.ts	48.31% <100.00%> (-0.58%)	⬇️
src/model/input.ts	88.27% <100.00%> (+0.33%)	⬆️
src/model/docker.ts	10.63% <0.00%> (ø)
src/model/exec-with-error-check.ts	13.33% <50.00%> (ø)

[GabLeRoux]

🎉 awesome! :D