-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 Updates #433
v4 Updates #433
Changes from 6 commits
2ac0baa
0228918
1db1562
2961406
4822b7e
b06a55b
07845ec
ce6dfd2
b9367c4
fa8c8fb
e30045a
d0fae52
63149c0
d180dbf
badf27e
8ebb6b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -454,6 +454,29 @@ to avoid any conflicts. | |
|
||
_**required:** `false`_ _**default:** `"/github/workspace"`_ | ||
|
||
#### dockerCpuLimit | ||
|
||
Number of CPU cores to assign the Windows docker container. Defaults to all available cores when no | ||
value is specified. Can accept fractional values, ie 0.5 for half of a cpu core's execution time. | ||
|
||
_**required:** `false`_ _**default:** `""`_ | ||
|
||
#### dockerMemoryLimit | ||
|
||
Amount of memory to assign the docker container. Defaults to 95% of total system memory rounded down | ||
to the nearest megabyte on Linux and 80% on Windows when no value is specified. On unrecognized | ||
platforms, defaults to 75% of total system memory. To manually specify a value, use the format | ||
\<number\>\<unit\>, where unit is either m or g. ie: 512m = 512 megabytes and 4g = 4 gigabytes. | ||
|
||
_**required:** `false`_ _**default:** `""`_ | ||
|
||
#### dockerIsolationMode | ||
|
||
Isolation mode to use for the docker container. Can be one of process, hyperv, or default. Only | ||
applicable on Windows. | ||
|
||
_**required:** `false`_ _**default:** `"default"`_ | ||
|
||
AndrewKahr marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here's a suggestion combining some the above ideas. I used a list for dockerCpuLimitNumber of CPU cores to assign to the Docker container. Defaults to all available cores when no value is specified. Can accept fractional values, e.g., 0.5 for half of a CPU core's execution time. required: dockerMemoryLimitAmount of memory to assign to the Docker container. Defaults to 95% of total system memory rounded down to the nearest megabyte on Linux and 80% on Windows. If the platform is unrecognized, it defaults to 75% of total system memory. To manually specify a value, use the format <number><unit>. The units can be:
required: dockerIsolationModeIsolation mode to use for the Docker container when running on Windows. Can be one of:
required: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like this a lot better, will be using this strategy. Excellent suggestion! |
||
## Outputs | ||
|
||
Below are outputs that can be accessed by using `${{ steps.myBuildStep.outputs.outputName }}`, where | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: simply wondering if we should have consistency with "Windows docker container" vs "docker container" in here.