Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More, better workflow editor Selenium tests - part 2. #5882

Merged
merged 1 commit into from
Apr 13, 2018
Merged

More, better workflow editor Selenium tests - part 2. #5882

merged 1 commit into from
Apr 13, 2018

Conversation

jmchilton
Copy link
Member

  • More stuff tested:
    • Connecting and disconnecting simple terminals as well as mapping terminals (ribbons).
    • Rendering simple workflows, workflow with output collections, workflow with mapping, and workflow with a subworkflow.
    • Collapsing side panels in the workflow editor.
  • Small tweaks to editor DOM.
  • More high-level abstractions for writing workflow editor tests (using these downstream in Allow rule based operations on existing collections. #5819).
  • More screenshots.

@galaxybot galaxybot added this to the 18.05 milestone Apr 12, 2018
@jmchilton jmchilton changed the title More, better workflow editor Selenium tests - part 2. [WIP] More, better workflow editor Selenium tests - part 2. Apr 12, 2018
@jmchilton
More, better workflow editor Selenium tests - part 2.
2cc6500 
- More stuff tested:
  - Connecting and disconnecting simple terminals as well as mapping terminals (ribbons).
  - Rendering simple workflows, workflow with output collections, workflow with mapping, and workflow with a subworkflow.
  - Collapsing side panels in the workflow editor.
- Small tweaks to editor DOM.
- More screenshots.
@jmchilton jmchilton changed the title [WIP] More, better workflow editor Selenium tests - part 2. More, better workflow editor Selenium tests - part 2. Apr 13, 2018
@dannon dannon merged commit 6e16b77 into galaxyproject:dev Apr 13, 2018
@jmchilton
Copy link
Member Author

Thanks for the merge @dannon !

@jmchilton jmchilton deleted the editor_tests_2 branch April 13, 2018 13:39
@dannon
Copy link
Member

dannon commented Apr 13, 2018

Sure, thanks for all the new and updated tests!

@jmchilton jmchilton mentioned this pull request Apr 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/testing/selenium area/workflows kind/enhancement
Projects
None yet
Milestone
18.05
Development

Successfully merging this pull request may close these issues.
3 participants
@jmchilton @dannon @galaxybot