More, better workflow run Selenium tests. #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jmchilton
commented
Apr 13, 2018
jmchilton
commented
- Improve the abstractions used by some API tests to allow them to be shared with Selenium testing.
- Improve robustness of Selenium workflow tests so that they don't need to assume a fresh user is executing the test.
- Add a new Selenium workflow test that actually specifies inputs (the existing test just assumes the history only has one dataset and that is selected by default).
- Implement better abstractions for these tests to enable more testing, more easily. These are being used here a bit and downstream in Allow rule based operations on existing collections. #5819.
- Small bug fix to improve performance of workflow editor tests from More, better workflow editor Selenium tests - part 2. #5882.
jmchilton
force-pushed
the
selenium_workflow_run
branch
from
4ee7220 to
03ddd92
Compare
jmchilton
force-pushed
the
selenium_workflow_run
branch
from
03ddd92 to
39bf576
Compare
jmchilton
force-pushed
the
selenium_workflow_run
branch
from
39bf576 to
0d26c2f
Compare
Use the more abstract test_data specification that will translate to GUI testing.
Re-use test_data specification used by many of the API workflow tests and a workflow used by another test. Add abstractions and DOM element for mapping labeled test data to tool form inputs.
jmchilton
force-pushed
the
selenium_workflow_run
branch
from
0d26c2f to
aafd9de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.