Don't catch ParameterValueError after persisting values in database

[mvdbeek]

params_from_strings is called from within the compute environment, where we generate the command line, which is after we've persisted job parameters:

galaxy/lib/galaxy/tools/evaluation.py

Line 137 in 5addd00

incoming = self.tool.params_from_strings(incoming, self.app)

This is too late to decide to skip or null parameter values. Luckily it seems this isn't needed (anymore ?) as all tests are passing.

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[bgruening]

A rebase and then ship it?