Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't catch ParameterValueError after persisting values in database #18017

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Don't catch ParameterValueError after persisting values in database #18017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lib/galaxy/tools/parameters/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from .basic import (
DataCollectionToolParameter,
DataToolParameter,
ParameterValueError,
SelectToolParameter,
ToolParameter,
)
Expand Down Expand Up @@ -291,10 +290,8 @@ def params_from_strings(params: Dict[str, Union[Group, ToolParameter]], param_va
# This would resolve a lot of back and forth in the various to/from methods.
value = safe_loads(value)
if param:
try:
value = param.value_from_basic(value, app, ignore_errors)
except ParameterValueError:
continue
# if ignore_error is true we return the value unmodified
value = param.value_from_basic(value, app, ignore_errors)
rval[key] = value
return rval

Expand Down
Loading