Merge pull request #18014 from mvdbeek/debug_and_fix_hidless_hdas

[24.0] Don't commit without having set a hid
galaxyproject · Apr 18, 2024 · 5addd00 · 5addd00
2 parents 066dbba + 37bc454
commit 5addd00
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/lib/galaxy/tools/actions/upload_common.py b/lib/galaxy/tools/actions/upload_common.py
@@ -140,8 +140,6 @@ def __new_history_upload(trans, uploaded_dataset, history=None, state=None):
         hda.state = state
     else:
         hda.state = hda.states.QUEUED
-    with transaction(trans.sa_session):
-        trans.sa_session.commit()
     history.add_dataset(hda, genome_build=uploaded_dataset.dbkey, quota=False)
     permissions = trans.app.security_agent.history_get_default_permissions(history)
     trans.app.security_agent.set_all_dataset_permissions(hda.dataset, permissions, new=True, flush=False)