Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and tests with SEPOLIA_RPC_URL getter function #2004

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

tomek0123456789
Copy link
Contributor

@tomek0123456789 tomek0123456789 commented Apr 11, 2024

commit-id:99e99636

Apply review suggestions to tests (to rebase)

Update release workflow

Replacing placeholders in a different test function (to rebase)

Remove env var from forks (to rebase)

Update tests once again

fix invalid ci

Tests, CI updates


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@tomek0123456789 tomek0123456789 changed the title Update tests with RPC_URL getter function Update CI and tests with NODE_URL getter function Apr 12, 2024
@tomek0123456789 tomek0123456789 force-pushed the spr/master/99e99636 branch 3 times, most recently from 6852c4d to faf71aa Compare April 16, 2024 15:25
@tomek0123456789 tomek0123456789 marked this pull request as ready for review April 16, 2024 15:42
@tomek0123456789 tomek0123456789 requested a review from a team as a code owner April 16, 2024 15:42
@tomek0123456789 tomek0123456789 requested review from Arcticae, drknzz, piotmag769, Draggu, THenry14 and ddoktorski and removed request for a team April 16, 2024 15:42
.github/workflows/ci.yml Outdated Show resolved Hide resolved
crates/forge/tests/e2e/common/runner.rs Outdated Show resolved Hide resolved
crates/forge/tests/e2e/diagnostics_and_plugins.rs Outdated Show resolved Hide resolved
@tomek0123456789 tomek0123456789 changed the title Update CI and tests with NODE_URL getter function Update CI and tests with SEPOLIA_RPC_URL getter function Apr 24, 2024
crates/forge/tests/e2e/diagnostics_and_plugins.rs Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
commit-id:918e569e

Fix cargo lint errors

Change implementation of rpc_url()

rpc_url() -> node_url() (to rebase)

Apply review suggestions (to rebase)

Envs from dotenv (to rebase)

Add .env.template file, rename functions once again (to rebase)
commit-id:99e99636

Apply review suggestions to tests (to rebase)

Update release workflow

Replacing placeholders in a different test function (to rebase)

Remove env var from forks (to rebase)

Update tests once again

fix invalid ci

Tests, CI updates
Copy link
Contributor

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

github-merge-queue bot pushed a commit that referenced this pull request Apr 26, 2024
commit-id:918e569e

Fix cargo lint errors

Change implementation of rpc_url()

rpc_url() -> node_url() (to rebase)

Apply review suggestions (to rebase)

Envs from dotenv (to rebase)

Add .env.template file, rename functions once again (to rebase)

---

**Stack**:
- #2006
- #2004
- #2003⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/master/918e569e to master April 26, 2024 10:59
@tomek0123456789 tomek0123456789 added this pull request to the merge queue Apr 26, 2024
Merged via the queue into master with commit 9c82de3 Apr 26, 2024
13 checks passed
@tomek0123456789 tomek0123456789 deleted the spr/master/99e99636 branch April 26, 2024 12:08
Arcticae added a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants