Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to retrieve SEPOLIA_RPC_URL #2003

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Add functions to retrieve SEPOLIA_RPC_URL #2003

merged 1 commit into from
Apr 26, 2024

Conversation

tomek0123456789
Copy link
Contributor

@tomek0123456789 tomek0123456789 commented Apr 11, 2024 •
edited
Loading

commit-id:918e569e

Fix cargo lint errors

Change implementation of rpc_url()

rpc_url() -> node_url() (to rebase)

Apply review suggestions (to rebase)

Envs from dotenv (to rebase)

Add .env.template file, rename functions once again (to rebase)

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Apr 11, 2024
Closed
Merged
Merged
@tomek0123456789 tomek0123456789 changed the title Add methods to retrieve RPC_URL Add functions to retrieve RPC_URL Apr 11, 2024
@tomek0123456789 tomek0123456789 force-pushed the spr/master/918e569e branch 2 times, most recently from c0fb9da to c6602e3 Compare April 11, 2024 15:56
@tomek0123456789 tomek0123456789 changed the title Add functions to retrieve RPC_URL Add functions to retrieve NODE_URL Apr 12, 2024
@tomek0123456789 tomek0123456789 force-pushed the spr/master/918e569e branch 2 times, most recently from 0fa0773 to 0904980 Compare April 16, 2024 15:25
@tomek0123456789 tomek0123456789 marked this pull request as ready for review April 16, 2024 15:42
Draggu
Draggu approved these changes Apr 16, 2024
View reviewed changes
crates/shared/src/test_utils/mod.rs Outdated Show resolved Hide resolved
crates/shared/src/test_utils/mod.rs Outdated Show resolved Hide resolved
@tomek0123456789 tomek0123456789 force-pushed the spr/master/918e569e branch 2 times, most recently from 2c59a45 to 1ce96bb Compare April 17, 2024 10:14
@tomek0123456789 tomek0123456789 changed the title Add functions to retrieve NODE_URL Add functions to retrieve SEPOLIA_RPC_URL Apr 24, 2024
@tomek0123456789
Add functions to retrieve SEPOLIA_RPC_URL
0f7f4c9 
commit-id:918e569e

Fix cargo lint errors

Change implementation of rpc_url()

rpc_url() -> node_url() (to rebase)

Apply review suggestions (to rebase)

Envs from dotenv (to rebase)

Add .env.template file, rename functions once again (to rebase)
@tomek0123456789 tomek0123456789 added this pull request to the merge queue Apr 26, 2024
Merged via the queue into master with commit 7451cca Apr 26, 2024
13 checks passed
@tomek0123456789 tomek0123456789 deleted the spr/master/918e569e branch April 26, 2024 10:59
@tomek0123456789 tomek0123456789 mentioned this pull request Apr 26, 2024
Closed
Arcticae added a commit that referenced this pull request Jun 6, 2024
@Arcticae
Revert "Add functions to retrieve SEPOLIA_RPC_URL (#2003)"
9d7d883 
This reverts commit 7451cca.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae approved these changes

@ddoktorski ddoktorski ddoktorski left review comments

@THenry14 THenry14 THenry14 approved these changes

@piotmag769 piotmag769 piotmag769 approved these changes

@Draggu Draggu Draggu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomek0123456789 @THenry14 @Arcticae @ddoktorski @piotmag769 @Draggu