Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace {{ NODE_RPC_URL }} on .cairo.template files only #2074

Closed
tomek0123456789 opened this issue Apr 25, 2024 · 2 comments
Closed

Replace {{ NODE_RPC_URL }} on .cairo.template files only #2074

tomek0123456789 opened this issue Apr 25, 2024 · 2 comments
Labels
good first issue Good for newcomers snforge

Comments

@tomek0123456789
Copy link
Contributor

tomek0123456789 commented Apr 25, 2024

Which components does the task require to be changed? (think hard pls)

snforge

Description

replace_node_rpc_url_placeholders is called whenever a test package (from crates/forge/tests/data/) is being set up for a test. It then processes all the files inside that set up package, no matter their extension. Because of that, it searches for {{ NODE_RPC_URL }} in all of the project files, making unnecessary overhead - it should only read from files that have .cairo.template extension.

  1. Change function implementation to replace contents of only those files that have the .cairo.template extension.
  2. Change extension of .cairo files in /crates/forge/tests/data/ that contain {{ NODE_RPC_URL }} string to .cairo.template.

Original discussion here.

Search in code by TODO (#2074)

@SourishBiswas23
Copy link

Hey! I would like to work on this. Could you assign it to me?

@Arcticae
Copy link
Contributor

Arcticae commented Apr 29, 2024

@SourishBiswas23 feel free to submit a PR 👍

@Arcticae Arcticae removed the new label Apr 29, 2024
@Arcticae Arcticae closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers snforge
Projects
Archived in project
Development

No branches or pull requests

3 participants