You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Which components does the task require to be changed? (think hard pls)
snforge
Description
replace_node_rpc_url_placeholders is called whenever a test package (from crates/forge/tests/data/) is being set up for a test. It then processes all the files inside that set up package, no matter their extension. Because of that, it searches for {{ NODE_RPC_URL }} in all of the project files, making unnecessary overhead - it should only read from files that have .cairo.template extension.
Change function implementation to replace contents of only those files that have the .cairo.template extension.
Change extension of .cairo files in /crates/forge/tests/data/ that contain {{ NODE_RPC_URL }} string to .cairo.template.
Which components does the task require to be changed? (think hard pls)
snforge
Description
replace_node_rpc_url_placeholders
is called whenever a test package (fromcrates/forge/tests/data/
) is being set up for a test. It then processes all the files inside that set up package, no matter their extension. Because of that, it searches for{{ NODE_RPC_URL }}
in all of the project files, making unnecessary overhead - it should only read from files that have.cairo.template
extension..cairo.template
extension..cairo
files in/crates/forge/tests/data/
that contain{{ NODE_RPC_URL }}
string to.cairo.template
.Original discussion here.
Search in code by
TODO (#2074)
The text was updated successfully, but these errors were encountered: