-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indexer): Add processor to docker-compose #5952
Conversation
roninjin10
commented
Jun 9, 2023
- Add processor to docker-compose
- this is still a wip
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Semgrep found 1
Found an HTTP server without TLS. Use 'http.ListenAndServeTLS' instead. See https://golang.org/pkg/net/http/#ListenAndServeTLS for more information. Ignore this finding from use-tls. |
afc5509
to
242ec64
Compare
eb8e6a0
to
1db1d37
Compare
242ec64
to
9d0c422
Compare
1db1d37
to
207dd85
Compare
9d0c422
to
5e0c6ab
Compare
207dd85
to
d564c45
Compare
Semgrep found 12
Please create a Linear ticket for this TODO. Ignore this finding from todos_require_linear. |
5e0c6ab
to
2cbe19d
Compare
d564c45
to
8c091f6
Compare
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Semgrep found 54
An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. Ignore this finding from third-party-action-not-pinned-to-commit-sha.Semgrep found 1
Potential Semgrep found 3
Iteration over a possibly empty map Semgrep found 1
Detected a dynamic value being used with urllib. urllib supports 'file://' schemes, so a dynamic value controlled by a malicious actor may allow them to read arbitrary files. Audit uses of urllib calls to ensure user data cannot control the URLs, or consider using the 'requests' library instead. Ignore this finding from dynamic-urllib-use-detected.Semgrep found 4
Dynamically rendering arbitrary HTML on your website can be very dangerous because it can easily lead to XSS vulnerabilities. Only use HTML interpolation on trusted content and never on user-provided content. Ignore this finding from avoid-v-html.Semgrep found 6
Detected possible user input going into a View Dataflow Graphflowchart LR
classDef invis fill:white, stroke: none
classDef default fill:#e7f5ff, color:#1c7fd6, stroke: none
subgraph File0["<b>packages/hardhat-deploy-config/src/plugin.ts</b>"]
direction LR
%% Source
subgraph Source
direction LR
v0("<b>[Line: 16]</b> userPath")
end
%% Intermediate
subgraph Traces0[Traces]
direction TB
v2("<b>[Line: 16]</b> userPath")
end
%% Sink
subgraph Sink
direction LR
v1("<b>[Line: 23]</b> userPath")
end
end
%% Class Assignment
Source:::invis
Sink:::invis
Traces0:::invis
File0:::invis
%% Connections
Source --> Traces0
Traces0 --> Sink
%% Clickable
click v0 href "https://github.com/ethereum-optimism/optimism/blob/515f0a372540cb1b1fd5b32f23fc0aca6deb3064/packages/hardhat-deploy-config/src/plugin.ts#L16" "View in source" _blank
click v1 href "https://github.com/ethereum-optimism/optimism/blob/515f0a372540cb1b1fd5b32f23fc0aca6deb3064/packages/hardhat-deploy-config/src/plugin.ts#L23" "View in source" _blank
click v2 href "https://github.com/ethereum-optimism/optimism/blob/515f0a372540cb1b1fd5b32f23fc0aca6deb3064/packages/hardhat-deploy-config/src/plugin.ts#L16" "View in source" _blank
Semgrep found 2
Semgrep found 1
Detected a possible denial-of-service via a zip bomb attack. By limiting the max bytes read, you can mitigate this attack. Semgrep found 1
Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'. Ignore this finding from no-direct-write-to-responsewriter.Semgrep found 2 Do not use Semgrep found 1
Please create a Linear ticket for this TODO. Ignore this finding from todos_require_linear.Semgrep found 1
Generic API Key detected Ignore this finding from detected-generic-api-key. |
Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review. |
515f0a3
to
7063c4f
Compare
7063c4f
to
c1d92d7
Compare
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |