feat(indexer): Load environment variables from .env

[roninjin10]

• add dotenv to automatically load .env when running outside of docker
• This is mostly just a nice-to-have because these env variables are also used in docker-compose so it saves configuration

[changeset-bot]

⚠️ No Changeset found

Latest commit: 538770d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[roninjin10]

Current dependencies on/for this PR:

• develop
  • PR chore(indexer): Update git ignroe to ignore binaries #5945
    • PR feat(indexer): Add healthz to api #5946
      • PR feat(indexer): Add indexer-refresh to makefile #5947
        • PR feat(indexer): Hook up api to cli app #5948
        • PR feat(indexer): Load environment variables from .env #5944 👈
          • PR fix(indexer): Add name to toml config #5969
            • PR feat(indexer): Hook up api to cli app #5980
              • PR feat(indexer): Connect processor to cli app #5950
                • PR feat(indexer): Add api to docker-compose #5951
                  • PR feat(indexer): Add processor to docker-compose #5952

This comment was auto-generated by Graphite.

[semgrep-app]

Semgrep found 1 use-tls finding:

• indexer/api/api.go: L104

Found an HTTP server without TLS. Use 'http.ListenAndServeTLS' instead. See https://golang.org/pkg/net/http/#ListenAndServeTLS for more information.

_{Ignore this finding from use-tls.}

[hamdiallam]

Why do we have a .env & also a toml configuration?

[roninjin10]

@hamdiallam you don't need a .env unless your toml file has environment variables in it. OUrs does for example here.

This is also why we don't panic when no .env is found. It's perfectly normal to use the toml file without environment variables or to pass in environment variables in a way other than .env

[rpcs]
l1-rpc = "${INDEXER_RPC_URL_L1}"
l2-rpc = "${INDEXER_RPC_URL_L2}"

[roninjin10]

We also need a .env file for docker-compose but that's unrelated to this pr

[semgrep-app]

Semgrep found 12 todos_require_linear findings:

• packages/data-transport-layer/src/services/l1-ingestion/service.ts: L167
• packages/data-transport-layer/src/utils/contracts.ts: L75
• packages/data-transport-layer/src/db/simple-db.ts: L10, L37
• packages/data-transport-layer/src/services/main/service.ts: L121
• packages/data-transport-layer/src/services/server/service.ts: L138, L226, L227, L228
• packages/data-transport-layer/src/services/l1-ingestion/handlers/sequencer-batch-appended.ts: L34, L88
• packages/data-transport-layer/src/utils/validation.ts: L41

Please create a Linear ticket for this TODO.

_{Ignore this finding from todos_require_linear.}

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[mergify]

Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review.

[mergify]

Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review.

[Inphi]

I'm not a fan of implicit configuration. It's too easy for users to accidentally leave a .env in their workspace and deploy that without easily knowing how the app behaves.

Though in our case, it seems fine since we use docker builds. But in general, I don't think this is good practice (including usage in the typescript BaseService apps)

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.